Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933404AbbHZUac (ORCPT ); Wed, 26 Aug 2015 16:30:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56584 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932084AbbHZUa2 (ORCPT ); Wed, 26 Aug 2015 16:30:28 -0400 Subject: Re: [PATCH v2 1/5] ACPI: add in a bad_madt_entry() function to eventually replace the macro To: Timur Tabi , Al Stone References: <1440022048-6285-1-git-send-email-al.stone@linaro.org> <1440022048-6285-2-git-send-email-al.stone@linaro.org> Cc: linux-acpi@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" , linaro-kernel@lists.linaro.org, linux-ia64@vger.kernel.org, patches@linaro.org, linux-pm@vger.kernel.org, linaro-acpi@lists.linaro.org, "Rafael J. Wysocki" , lkml , Len Brown From: Al Stone Message-ID: <55DE21E1.6070700@redhat.com> Date: Wed, 26 Aug 2015 14:30:25 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1327 Lines: 38 On 08/26/2015 09:38 AM, Timur Tabi wrote: > On Wed, Aug 19, 2015 at 5:07 PM, Al Stone wrote: >> + pr_err("Variable length MADT subtable %d is wrong size: %d\n", >> + entry->type, entry->length); >> + return 1; >> + } >> + } >> + } else { >> + if (entry->length != len) { >> + pr_err("MADT subtable %d is wrong size: %d\n", >> + len, entry->type); > > Can we make these a little more descriptive? > > pr_err("Variable length MADT subtable type %d is wrong size: %d, > should be %d\n", > entry->type, entry->length, len); > > pr_err("MADT subtable type %d is wrong size: %d, should be %d\n", > entry->type, entry->length, len); > Sure. It's always a fine line between verbose and not enough info. -- ciao, al ----------------------------------- Al Stone Software Engineer Red Hat, Inc. ahs3@redhat.com ----------------------------------- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/