Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752542AbbHZXcJ (ORCPT ); Wed, 26 Aug 2015 19:32:09 -0400 Received: from g9t5009.houston.hp.com ([15.240.92.67]:46047 "EHLO g9t5009.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751368AbbHZXcF (ORCPT ); Wed, 26 Aug 2015 19:32:05 -0400 Message-ID: <1440631796.14237.67.camel@hp.com> Subject: Re: [PATCH 2/2]: acpica/nfit: Rename not-armed bit definition From: Toshi Kani To: "Rafael J. Wysocki" Cc: Dan Williams , Rafael J Wysocki , Robert Moore , "linux-nvdimm@lists.01.org" , Linux ACPI , "linux-kernel@vger.kernel.org" , "Elliott, Robert (Server Storage)" Date: Wed, 26 Aug 2015 17:29:56 -0600 In-Reply-To: References: <1440606024-29873-1-git-send-email-toshi.kani@hp.com> <1440606024-29873-3-git-send-email-toshi.kani@hp.com> <1440623522.14237.57.camel@hp.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.4 (3.16.4-2.fc22) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2176 Lines: 47 On Thu, 2015-08-27 at 01:16 +0200, Rafael J. Wysocki wrote: > On Wed, Aug 26, 2015 at 11:12 PM, Toshi Kani wrote: > > On Wed, 2015-08-26 at 10:16 -0700, Dan Williams wrote: > > > On Wed, Aug 26, 2015 at 9:20 AM, Toshi Kani wrote: > > > > ACPI 6.0 NFIT Memory Device State Flags in Table 5-129 defines > > > > bit 3 as follows. > > > > > > > > Bit [3] set to 1 to indicate that the Memory Device is observed > > > > to be not armed prior to OSPM hand off. A Memory Device is > > > > considered armed if it is able to accept persistent writes. > > > > > > > > This bit is currently defined as ACPI_NFIT_MEM_ARMED, which can be > > > > confusing as if the Memory Device is armed when this bit is set. > > > > > > > > Change the name to ACPI_NFIT_MEM_NOT_ARMED per the spec. > > > > > > > > Signed-off-by: Toshi Kani > > > > Cc: Dan Williams > > > > Cc: Bob Moore > > > > Cc: Rafael J. Wysocki > > > > --- > > > > drivers/acpi/nfit.c | 6 +++--- > > > > drivers/acpi/nfit.h | 2 +- > > > > include/acpi/actbl1.h | 2 +- > > > > > > This file "include/acpi/actbl1.h" is owned by the ACPICA project so > > > any changes need to come through them. But that said, I'm not sure we > > > need friendly names at this level. > > > > I think the name is misleading, but I agree with the process and this > > patch2 can be dropped. It'd be nice if the ACPICA project can pick it > > up later when they have a chance, though. > > A good way to cause that to happen would be to send a patch to the > ACPICA development list + maintainers as per MAINTAINERS. Oh, I see. I did run get_maintainer.pl for this patch, but devel@acpica.org did not come out in output... So, I did not realize this email list. Thanks for the suggestion! -Toshi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/