Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753160AbbHZXzO (ORCPT ); Wed, 26 Aug 2015 19:55:14 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:43925 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751769AbbHZXzK (ORCPT ); Wed, 26 Aug 2015 19:55:10 -0400 Date: Wed, 26 Aug 2015 16:54:34 -0700 From: Calvin Owens To: "Nicholas A. Bellinger" CC: linux-scsi , linux-kernel , James Bottomley , Christoph Hellwig , Sreekanth Reddy , "MPT-FusionLinux.pdl" , Nicholas Bellinger , Subject: Re: [PATCH 0/2] mpt3sas: Reference counting fixes from in-flight mpt2sas Message-ID: <20150826235434.GA8843@mail.thefacebook.com> References: <1440562184-23945-1-git-send-email-nab@daterainc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <1440562184-23945-1-git-send-email-nab@daterainc.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [192.168.52.123] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151,1.0.33,0.0.0000 definitions=2015-08-27_01:2015-08-26,2015-08-26,1970-01-01 signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1950 Lines: 54 On Wednesday 08/26 at 04:09 +0000, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > Hi James & Co, > > This series is a mpt3sas forward port of Calvin Owens' in-flight > reference counting bugfixes for mpt2sas LLD code here: > > [PATCH v4 0/2] Fixes for memory corruption in mpt2sas > http://marc.info/?l=linux-scsi&m=143951695904115&w=2 Nicholas, I'm glad to hear these fixes were helpful! I was planning on porting to mpt3sas in the near future, thanks for saving me the trouble :) Calvin > The differences between mpt2sas + mpt3sas in this area are very, > very small, and is required to address a NULL pointer dereference > OOPsen in _scsih_probe_sas() -> mpt3sas_transport_port_add() -> > sas_port_add_phy() that I've been hitting occasionally on boot > during initial LUN scan. > > So far this code has been tested on v3.14.47 with a small cluster > using SAS3008 HBAs plus a few preceeding upstream mpt3sas patches > so these patches apply cleanly, and with the changes in place the > original OOPsen appears to be resolved. > > This patch series is cut atop v4.2-rc1 code, and barring any > objections from Avago folks et al., should be considered along > with Calvin's mpt2sas patch set for v4.3-rc1 code. > > Thank you, > > --nab > > Nicholas Bellinger (2): > mpt3sas: Refcount sas_device objects and fix unsafe list usage > mpt3sas: Refcount fw_events and fix unsafe list usage > > drivers/scsi/mpt3sas/mpt3sas_base.h | 23 +- > drivers/scsi/mpt3sas/mpt3sas_scsih.c | 592 ++++++++++++++++++++++--------- > drivers/scsi/mpt3sas/mpt3sas_transport.c | 12 +- > 3 files changed, 449 insertions(+), 178 deletions(-) > > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/