Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752349AbbH0BKY (ORCPT ); Wed, 26 Aug 2015 21:10:24 -0400 Received: from mail.kmu-office.ch ([178.209.48.109]:51609 "EHLO mail.kmu-office.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751482AbbH0BKW (ORCPT ); Wed, 26 Aug 2015 21:10:22 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Date: Wed, 26 Aug 2015 18:10:05 -0700 From: Stefan Agner To: Brian Norris Cc: dwmw2@infradead.org, sebastian@breakpoint.cc, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, shawn.guo@linaro.org, kernel@pengutronix.de, boris.brezillon@free-electrons.com, marb@ixxat.de, aaron@tastycactus.com, bpringlemeir@gmail.com, linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, albert.aribaud@3adev.fr, klimov.linux@gmail.com, Bill Pringlemeir Subject: Re: [PATCH v10 1/5] mtd: nand: vf610_nfc: Freescale NFC for VF610, MPC5125 and others In-Reply-To: <20150825203412.GM81844@google.com> References: <1438594050-4595-1-git-send-email-stefan@agner.ch> <1438594050-4595-2-git-send-email-stefan@agner.ch> <20150825203412.GM81844@google.com> Message-ID: User-Agent: Roundcube Webmail/1.1.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1222 Lines: 36 On 2015-08-25 13:34, Brian Norris wrote: > One more thing... > > On Mon, Aug 03, 2015 at 11:27:26AM +0200, Stefan Agner wrote: >> --- /dev/null >> +++ b/drivers/mtd/nand/vf610_nfc.c >> @@ -0,0 +1,645 @@ > ... >> +struct vf610_nfc { >> + struct mtd_info mtd; >> + struct nand_chip chip; >> + struct device *dev; >> + void __iomem *regs; >> + struct completion cmd_done; >> + uint buf_offset; >> + int page_sz; > > AFAICT (even with the 2nd patch), you never really use this field. You > just set it/increment it, but don't use it for anything. Kill it? It is used in the write path, I think I meant to use it for subpage writes, when I thought it would just mean to transfer only parts of the page to the controller. However, as the subpage discussion basically concluded in not using it for now on this controller, we can as well transfer the complete page (page_sz). Or is there another case in which vf610_nfc_write_buf could be called with less than page_sz? -- Stefan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/