Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752487AbbH0CHJ (ORCPT ); Wed, 26 Aug 2015 22:07:09 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:33803 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751016AbbH0CHH (ORCPT ); Wed, 26 Aug 2015 22:07:07 -0400 Date: Wed, 26 Aug 2015 19:06:32 -0700 From: Calvin Owens To: "Nicholas A. Bellinger" CC: linux-scsi , linux-kernel , James Bottomley , Christoph Hellwig , Sreekanth Reddy , "MPT-FusionLinux.pdl" , Nicholas Bellinger Subject: Re: [PATCH 2/2] mpt3sas: Refcount fw_events and fix unsafe list usage Message-ID: <20150827020632.GA12485@mail.thefacebook.com> References: <1440562184-23945-1-git-send-email-nab@daterainc.com> <1440562184-23945-3-git-send-email-nab@daterainc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <1440562184-23945-3-git-send-email-nab@daterainc.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [192.168.52.123] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151,1.0.33,0.0.0000 definitions=2015-08-27_01:2015-08-26,2015-08-26,1970-01-01 signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1254 Lines: 29 On Wednesday 08/26 at 04:09 +0000, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > The fw_event_work struct is concurrently referenced at shutdown, so > add a refcount to protect it, and refactor the code to use it. > > Additionally, refactor _scsih_fw_event_cleanup_queue() such that it > no longer iterates over the list without holding the lock, since > _firmware_event_work() concurrently deletes items from the list. > > This patch is a port of Calvin's PATCH-v4 for mpt2sas code. > > Cc: Calvin Owens > Cc: Christoph Hellwig > Cc: Sreekanth Reddy > Cc: MPT-FusionLinux.pdl > Signed-off-by: Nicholas Bellinger > --- > drivers/scsi/mpt3sas/mpt3sas_scsih.c | 116 ++++++++++++++++++++++++++++------- > 1 file changed, 94 insertions(+), 22 deletions(-) Looks good, thanks again for this. Reviewed-by: Calvin Owens -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/