Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752583AbbH0DHo (ORCPT ); Wed, 26 Aug 2015 23:07:44 -0400 Received: from mga01.intel.com ([192.55.52.88]:14125 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750773AbbH0DHm (ORCPT ); Wed, 26 Aug 2015 23:07:42 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,420,1437462000"; d="scan'208";a="756216023" Date: Wed, 26 Aug 2015 21:07:40 -0600 From: Ross Zwisler To: Toshi Kani Cc: dan.j.williams@intel.com, rafael.j.wysocki@intel.com, linux-nvdimm@ml01.01.org, robert.moore@intel.com, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH 1/2]: nfit: Clarify memory device state flags strings Message-ID: <20150827030740.GB4438@linux.intel.com> References: <1440606024-29873-1-git-send-email-toshi.kani@hp.com> <1440606024-29873-2-git-send-email-toshi.kani@hp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1440606024-29873-2-git-send-email-toshi.kani@hp.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2383 Lines: 51 On Wed, Aug 26, 2015 at 10:20:23AM -0600, Toshi Kani wrote: > diff --git a/drivers/acpi/nfit.c b/drivers/acpi/nfit.c > index c3fe206..6993ff2 100644 > --- a/drivers/acpi/nfit.c > +++ b/drivers/acpi/nfit.c > @@ -701,12 +701,13 @@ static ssize_t flags_show(struct device *dev, > { > u16 flags = to_nfit_memdev(dev)->flags; > > - return sprintf(buf, "%s%s%s%s%s\n", > - flags & ACPI_NFIT_MEM_SAVE_FAILED ? "save " : "", > - flags & ACPI_NFIT_MEM_RESTORE_FAILED ? "restore " : "", > - flags & ACPI_NFIT_MEM_FLUSH_FAILED ? "flush " : "", > - flags & ACPI_NFIT_MEM_ARMED ? "arm " : "", > - flags & ACPI_NFIT_MEM_HEALTH_OBSERVED ? "smart " : ""); > + return sprintf(buf, "%s%s%s%s%s%s\n", > + flags & ACPI_NFIT_MEM_SAVE_FAILED ? "save_fail " : "", > + flags & ACPI_NFIT_MEM_RESTORE_FAILED ? "restore_fail " : "", > + flags & ACPI_NFIT_MEM_FLUSH_FAILED ? "flush_fail " : "", > + flags & ACPI_NFIT_MEM_ARMED ? "not_arm " : "", Assuming we do want to update these strings to be more friendly, "not_armed" probably makes more sense than "not_arm". Also applies to the 2nd hunk below. > + flags & ACPI_NFIT_MEM_HEALTH_OBSERVED ? "smart_event " : "", > + flags & ACPI_NFIT_MEM_HEALTH_ENABLED ? "notify_enabled " : ""); > } > static DEVICE_ATTR_RO(flags); > > @@ -834,11 +835,11 @@ static int acpi_nfit_register_dimms(struct acpi_nfit_desc *acpi_desc) > continue; > > dev_info(acpi_desc->dev, "%s: failed: %s%s%s%s\n", > - nvdimm_name(nvdimm), > - mem_flags & ACPI_NFIT_MEM_SAVE_FAILED ? "save " : "", > - mem_flags & ACPI_NFIT_MEM_RESTORE_FAILED ? "restore " : "", > - mem_flags & ACPI_NFIT_MEM_FLUSH_FAILED ? "flush " : "", > - mem_flags & ACPI_NFIT_MEM_ARMED ? "arm " : ""); > + nvdimm_name(nvdimm), > + mem_flags & ACPI_NFIT_MEM_SAVE_FAILED ? "save_fail " : "", > + mem_flags & ACPI_NFIT_MEM_RESTORE_FAILED ? "restore_fail ":"", > + mem_flags & ACPI_NFIT_MEM_FLUSH_FAILED ? "flush_fail " : "", > + mem_flags & ACPI_NFIT_MEM_ARMED ? "not_arm " : ""); While you're in here, is there a reason not to include the last two flags (smart_event and notify_enabled) in this dev_info() output? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/