Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752182AbbH1AjF (ORCPT ); Thu, 27 Aug 2015 20:39:05 -0400 Received: from ozlabs.org ([103.22.144.67]:33729 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751289AbbH1AjD (ORCPT ); Thu, 27 Aug 2015 20:39:03 -0400 From: Rusty Russell To: Dan Streetman , Seth Jennings , Andrew Morton Cc: linux-kernel , Linux-MM , Dan Streetman Subject: Re: [PATCH 1/2] module: export param_free_charp() In-Reply-To: <1440613970-23913-2-git-send-email-ddstreet@ieee.org> References: <1440613970-23913-1-git-send-email-ddstreet@ieee.org> <1440613970-23913-2-git-send-email-ddstreet@ieee.org> User-Agent: Notmuch/0.17 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Thu, 27 Aug 2015 13:45:57 +0930 Message-ID: <876141icxu.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1854 Lines: 53 Dan Streetman writes: > Change the param_free_charp() function from static to exported. > > It is used by zswap in the next patch. > > Signed-off-by: Dan Streetman Acked-by: Rusty Russell Thanks! Rusty. > --- > include/linux/moduleparam.h | 1 + > kernel/params.c | 3 ++- > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/include/linux/moduleparam.h b/include/linux/moduleparam.h > index c12f214..52666d9 100644 > --- a/include/linux/moduleparam.h > +++ b/include/linux/moduleparam.h > @@ -386,6 +386,7 @@ extern int param_get_ullong(char *buffer, const struct kernel_param *kp); > extern const struct kernel_param_ops param_ops_charp; > extern int param_set_charp(const char *val, const struct kernel_param *kp); > extern int param_get_charp(char *buffer, const struct kernel_param *kp); > +extern void param_free_charp(void *arg); > #define param_check_charp(name, p) __param_check(name, p, char *) > > /* We used to allow int as well as bool. We're taking that away! */ > diff --git a/kernel/params.c b/kernel/params.c > index b6554aa..93a380a 100644 > --- a/kernel/params.c > +++ b/kernel/params.c > @@ -325,10 +325,11 @@ int param_get_charp(char *buffer, const struct kernel_param *kp) > } > EXPORT_SYMBOL(param_get_charp); > > -static void param_free_charp(void *arg) > +void param_free_charp(void *arg) > { > maybe_kfree_parameter(*((char **)arg)); > } > +EXPORT_SYMBOL(param_free_charp); > > const struct kernel_param_ops param_ops_charp = { > .set = param_set_charp, > -- > 2.1.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/