Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752872AbbH0F31 (ORCPT ); Thu, 27 Aug 2015 01:29:27 -0400 Received: from mail-la0-f68.google.com ([209.85.215.68]:33979 "EHLO mail-la0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751612AbbH0F3Z (ORCPT ); Thu, 27 Aug 2015 01:29:25 -0400 MIME-Version: 1.0 In-Reply-To: <1440602865-30468-1-git-send-email-nathan.sullivan@ni.com> References: <1440602865-30468-1-git-send-email-nathan.sullivan@ni.com> Date: Thu, 27 Aug 2015 10:59:22 +0530 Message-ID: Subject: Re: [PATCH 1/2] usb: chipidea: add xilinx zynq platform data From: sundeep subbaraya To: Nathan Sullivan , Subbaraya Sundeep Bhatta Cc: Peter.Chen@freescale.com, robh+dt@kernel.org, pawel.moll@arm.com, Mark Rutland , ijc+devicetree@hellion.org.uk, galak@codeaurora.org, Greg Kroah-Hartman , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3748 Lines: 105 Hi, On Wed, Aug 26, 2015 at 8:57 PM, Nathan Sullivan wrote: > The Xilinx Zynq udc does not need the CI_HDRC_DISABLE_STREAMING flag, > unlike the default platform data. Add platform data specific to the > Zynq udc. > > Based on a patch by the same name from the Xilinx vendor tree. I am that Xilinx guy who sent this patch :). It is in Xilinx tree as temporary fix and I did not debug further why UDC works only when streaming is enabled. Probably this is right time to post my question here. I was expecting like: Streaming disabled - both low bandwidth and high bandwidth systems should work fine Streaming enabled - only for high bandwidth systems but this is not the case, Zynq UDC works only when Streaming is enabled. Please correct me if I am wrong. Thanks, Sundeep > > Signed-off-by: Nathan Sullivan > --- > drivers/usb/chipidea/ci_hdrc_usb2.c | 25 +++++++++++++++++++------ > 1 file changed, 19 insertions(+), 6 deletions(-) > > diff --git a/drivers/usb/chipidea/ci_hdrc_usb2.c b/drivers/usb/chipidea/ci_hdrc_usb2.c > index 9eae1a1..4456d2c 100644 > --- a/drivers/usb/chipidea/ci_hdrc_usb2.c > +++ b/drivers/usb/chipidea/ci_hdrc_usb2.c > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -30,18 +31,36 @@ static const struct ci_hdrc_platform_data ci_default_pdata = { > .flags = CI_HDRC_DISABLE_STREAMING, > }; > > +static struct ci_hdrc_platform_data ci_zynq_pdata = { > + .capoffset = DEF_CAPOFFSET, > +}; > + > +static const struct of_device_id ci_hdrc_usb2_of_match[] = { > + { .compatible = "chipidea,usb2"}, > + { .compatible = "xlnx,zynq-usb-2.20a", .data = &ci_zynq_pdata}, > + { } > +}; > +MODULE_DEVICE_TABLE(of, ci_hdrc_usb2_of_match); > + > static int ci_hdrc_usb2_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > struct ci_hdrc_usb2_priv *priv; > struct ci_hdrc_platform_data *ci_pdata = dev_get_platdata(dev); > int ret; > + const struct of_device_id *match; > > if (!ci_pdata) { > ci_pdata = devm_kmalloc(dev, sizeof(*ci_pdata), GFP_KERNEL); > *ci_pdata = ci_default_pdata; /* struct copy */ > } > > + match = of_match_device(ci_hdrc_usb2_of_match, &pdev->dev); > + if (match && match->data) { > + /* struct copy */ > + *ci_pdata = *(struct ci_hdrc_platform_data *)match->data; > + } > + > priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); > if (!priv) > return -ENOMEM; > @@ -96,12 +115,6 @@ static int ci_hdrc_usb2_remove(struct platform_device *pdev) > return 0; > } > > -static const struct of_device_id ci_hdrc_usb2_of_match[] = { > - { .compatible = "chipidea,usb2" }, > - { } > -}; > -MODULE_DEVICE_TABLE(of, ci_hdrc_usb2_of_match); > - > static struct platform_driver ci_hdrc_usb2_driver = { > .probe = ci_hdrc_usb2_probe, > .remove = ci_hdrc_usb2_remove, > -- > 1.7.10.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/