Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752751AbbH0JsI (ORCPT ); Thu, 27 Aug 2015 05:48:08 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:34177 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750725AbbH0JsF (ORCPT ); Thu, 27 Aug 2015 05:48:05 -0400 MIME-Version: 1.0 In-Reply-To: <1440577578-15813-7-git-send-email-aneesh.kumar@linux.vnet.ibm.com> References: <1440577578-15813-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1440577578-15813-7-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Date: Thu, 27 Aug 2015 12:48:04 +0300 Message-ID: Subject: Re: [PATCH V2 06/10] kasan: Allow arch to overrride kasan shadow offsets From: Andrey Ryabinin To: "Aneesh Kumar K.V" Cc: Benjamin Herrenschmidt , paulus@samba.org, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2123 Lines: 63 2015-08-26 11:26 GMT+03:00 Aneesh Kumar K.V : > Some archs may want to provide kasan shadow memory as a constant > offset from the address. Such arch even though cannot use inline kasan > support, they can work with outofline kasan support. > > Signed-off-by: Aneesh Kumar K.V > --- > include/linux/kasan.h | 3 +++ > mm/kasan/kasan.h | 3 +++ > 2 files changed, 6 insertions(+) > > diff --git a/include/linux/kasan.h b/include/linux/kasan.h > index 5486d777b706..e458ca64cdaf 100644 > --- a/include/linux/kasan.h > +++ b/include/linux/kasan.h > @@ -15,11 +15,14 @@ struct vm_struct; > #include > #include > > +#ifndef kasan_mem_to_shadow > static inline void *kasan_mem_to_shadow(const void *addr) > { > return (void *)((unsigned long)addr >> KASAN_SHADOW_SCALE_SHIFT) > + KASAN_SHADOW_OFFSET; > } > +#define kasan_mem_to_shadow kasan_mem_to_shadow Again, why we need this define here? I think it should be safe to remove it. > +#endif > > /* Enable reporting bugs after kasan_disable_current() */ > static inline void kasan_enable_current(void) > diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h > index deb547d5a916..c0686f2b1224 100644 > --- a/mm/kasan/kasan.h > +++ b/mm/kasan/kasan.h > @@ -57,11 +57,14 @@ struct kasan_global { > void kasan_report_error(struct kasan_access_info *info); > void kasan_report_user_access(struct kasan_access_info *info); > > +#ifndef kasan_shadow_to_mem > static inline const void *kasan_shadow_to_mem(const void *shadow_addr) > { > return (void *)(((unsigned long)shadow_addr - KASAN_SHADOW_OFFSET) > << KASAN_SHADOW_SCALE_SHIFT); > } > +#define kasan_shadow_to_mem kasan_shadow_to_mem ditto > +#endif > > static inline bool kasan_report_enabled(void) > { > -- > 2.5.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/