Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753147AbbH0Jyl (ORCPT ); Thu, 27 Aug 2015 05:54:41 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:48015 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751432AbbH0Jyj (ORCPT ); Thu, 27 Aug 2015 05:54:39 -0400 Message-ID: <55DEDE54.3040801@ti.com> Date: Thu, 27 Aug 2015 15:24:28 +0530 From: Kishon Vijay Abraham I User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Krzysztof Kozlowski , Marek Szyprowski , , , CC: Robert Baldyga , John Youn , Kukjin Kim , Kamil Debski Subject: Re: [PATCH 1/7] phy: exynos-usb2: add vbus regulator support References: <1440160723-6636-1-git-send-email-m.szyprowski@samsung.com> <1440160723-6636-2-git-send-email-m.szyprowski@samsung.com> <55D71D3E.3010807@ti.com> <55DC0173.9030702@samsung.com> <55DC073D.8050909@samsung.com> In-Reply-To: <55DC073D.8050909@samsung.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2410 Lines: 57 Hi, On Tuesday 25 August 2015 11:42 AM, Krzysztof Kozlowski wrote: > On 25.08.2015 14:47, Marek Szyprowski wrote: >> Hello, >> >> On 2015-08-21 14:44, Kishon Vijay Abraham I wrote: >>> On Friday 21 August 2015 06:08 PM, Marek Szyprowski wrote: >>>> Exynos USB2 PHY has separate power supply, which is usually provided by >>>> VBUS regulator. This patch adds support for it. VBUS regulator is >>>> optional, to keep compatibility with boards, which have VBUS provided >>>> from some always-on power source. >>>> >>>> Signed-off-by: Marek Szyprowski >>>> --- >>>> .../devicetree/bindings/phy/samsung-phy.txt | 3 +++ >>>> drivers/phy/phy-samsung-usb2.c | 25 >>>> ++++++++++++++++++++-- >>>> drivers/phy/phy-samsung-usb2.h | 2 ++ >>>> 3 files changed, 28 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/phy/samsung-phy.txt >>>> b/Documentation/devicetree/bindings/phy/samsung-phy.txt >>>> index 60c6f2a633e0..0289d3b07853 100644 >>>> --- a/Documentation/devicetree/bindings/phy/samsung-phy.txt >>>> +++ b/Documentation/devicetree/bindings/phy/samsung-phy.txt >>>> @@ -44,6 +44,9 @@ Required properties: >>>> - the "ref" clock is used to get the rate of the clock provided >>>> to the >>>> PHY module >>>> +Optional properties: >>>> +- vbus-supply: power-supply phandle for vbus power source >>> how about using phy-supply? >> >> I wanted to make it a bit more descriptive (vbus-supply is rather self >> explaining name) >> and keep it in line with Exynos usb3-drd phy, which already supports >> vbus-supply. >> If you think that this is a bad idea, a will use phy-supply then. > > This is actually supply for VBUS, not for the phy. Using phy-supply > would work fine and reduce the size of code... but would be rather a > hacky-use of phy and it could be misleading. > > I don't have strong feeling about this, both ideas have its advantages. > If I had to choose than I would like to use vbus-supply because of its > correctness with real-world (this is a VBUS after all). Alright.. lets use vbus-supply then. Thanks Kishon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/