Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752211AbbH0KUI (ORCPT ); Thu, 27 Aug 2015 06:20:08 -0400 Received: from e28smtp04.in.ibm.com ([122.248.162.4]:45042 "EHLO e28smtp04.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751444AbbH0KUF (ORCPT ); Thu, 27 Aug 2015 06:20:05 -0400 X-Helo: d28dlp01.in.ibm.com X-MailFrom: shilpa.bhat@linux.vnet.ibm.com X-RcptTo: linux-pm@vger.kernel.org Message-ID: <55DEE3A0.1090100@linux.vnet.ibm.com> Date: Thu, 27 Aug 2015 15:47:04 +0530 From: Shilpasri G Bhat User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Michael Ellerman CC: rjw@rjwysocki.net, stewart@linux.vnet.ibm.com, linux-pm@vger.kernel.org, viresh.kumar@linaro.org, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org Subject: Re: [PATCH] cpufreq: powernv: Export frequency throttle state of the chip through sysfs References: <1440666806-11760-1-git-send-email-shilpa.bhat@linux.vnet.ibm.com> <1440667890.18333.1.camel@ellerman.id.au> In-Reply-To: <1440667890.18333.1.camel@ellerman.id.au> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15082710-0013-0000-0000-00000707F5D6 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1346 Lines: 36 On 08/27/2015 03:01 PM, Michael Ellerman wrote: > On Thu, 2015-08-27 at 14:43 +0530, Shilpasri G Bhat wrote: >> Create a sysfs 'throttle' attribute per-chip(per-numa-node) to reflect >> the throttle state of the chip. The usersapce programs can poll on >> this attribute to keep an eye on the throttle state. Currently we >> print a log message to notify the user of throttling event. The >> performance-sensitive applications can monitor the throttle state >> using this attribute. > > Performance sensitive applications can *poll* on a sysfs file, which does a > loop over all chips and potentially spams the console with pr_crit() messages ? > > That does not sound like a recipe for success. Okay. > > What problem are we actually trying to solve here? How to export the throttle information to the user space, such that it is consumable by the applications (for example to discard the benchmark run if the frequency was throttled)? We already print the throttle information to console. Can we extend this to notify/broadcast as an event to the applications? Thanks and Regards, Shilpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/