Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752770AbbH0KXO (ORCPT ); Thu, 27 Aug 2015 06:23:14 -0400 Received: from ozlabs.org ([103.22.144.67]:35027 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751507AbbH0KXM (ORCPT ); Thu, 27 Aug 2015 06:23:12 -0400 Message-ID: <1440670990.18333.2.camel@ellerman.id.au> Subject: Re: [PATCH 2/7] selftests: add CFLAGS_EXTRA From: Michael Ellerman To: Bamvor Zhang Jian Cc: linux-kernel@vger.kernel.org, Mark Brown , khilman@linaro.org, tyler.baker@linaro.org, shuahkh@osg.samsung.com Date: Thu, 27 Aug 2015 20:23:10 +1000 In-Reply-To: <55DC6470.8030106@linaro.org> References: <1439559818-21666-1-git-send-email-bamvor.zhangjian@linaro.org> <1439559818-21666-3-git-send-email-bamvor.zhangjian@linaro.org> <1440388080.9176.6.camel@ellerman.id.au> <55DC6470.8030106@linaro.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1445 Lines: 43 On Tue, 2015-08-25 at 20:49 +0800, Bamvor Zhang Jian wrote: > > On 08/24/2015 11:48 AM, Michael Ellerman wrote: > > On Fri, 2015-08-14 at 21:43 +0800, Bamvor Jian Zhang wrote: > >> One may pass the "-I /path/to/headers -L /path/to/lib" through > >> CFLAGS_EXTRA for cross compiling. mqueue could compile pass > >> in this way when we provide the popt.h and libpopt.so. And kdbus > >> could compile pass with sys/capability and libcap.so > > > > There should be no need to define a new variable. > > > > You should just update the relevant Makefiles to use CFLAGS += rather than > > CFLAGS =. And then you can just specifiy CFLAGS on the command line. > yeap, it works for me. There is only one line need to be changed: OK, so please send a patch to update that Makefile. > diff --git a/tools/testing/selftests/mqueue/Makefile b/tools/testing/selftests/mqueue/Makefile > index 0e3b41e..ca8327f 100644 > --- a/tools/testing/selftests/mqueue/Makefile > +++ b/tools/testing/selftests/mqueue/Makefile > @@ -1,4 +1,4 @@ > -CFLAGS = -O2 > +CFLAGS += -O2 > > all: > $(CC) $(CFLAGS) mq_open_tests.c -o mq_open_tests -lrt And this can be simplified to: LDLIBS = -lrt all: mq_open_tests cheers -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/