Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753681AbbH0MEK (ORCPT ); Thu, 27 Aug 2015 08:04:10 -0400 Received: from twosheds.infradead.org ([90.155.92.209]:59357 "EHLO twosheds.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752771AbbH0MEH (ORCPT ); Thu, 27 Aug 2015 08:04:07 -0400 X-Greylist: delayed 3972 seconds by postgrey-1.27 at vger.kernel.org; Thu, 27 Aug 2015 08:04:07 EDT Message-ID: <36ddb60c1d22756234392a2d065a02cb.squirrel@twosheds.infradead.org> In-Reply-To: <31228.1440671938@warthog.procyon.org.uk> References: <20150826232622.GC8051@wotan.suse.de> <20150824210234.GI8051@wotan.suse.de> <476DC76E7D1DF2438D32BFADF679FC5601057D32@ORSMSX103.amr.corp.intel.com> <20150824225713.GJ8051@wotan.suse.de> <476DC76E7D1DF2438D32BFADF679FC5601058E78@ORSMSX103.amr.corp.intel.com> <1440462367.2737.4.camel@linux.vnet.ibm.com> <1440464705.2737.36.camel@linux.vnet.ibm.com> <14540.1440599584@warthog.procyon.org.uk> <31228.1440671938@warthog.procyon.org.uk> Date: Thu, 27 Aug 2015 10:57:23 -0000 Subject: Re: Linux Firmware Signing From: "David Woodhouse" To: "David Howells" Cc: "Luis R. Rodriguez" , dhowells@redhat.com, "Mimi Zohar" , "Andy Lutomirski" , "Kees Cook" , "Roberts, William C" , "linux-security-module@vger.kernel.org" , linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, "james.l.morris@oracle.com" , "serge@hallyn.com" , "Vitaly Kuznetsov" , "Paul Moore" , "Eric Paris" , selinux@tycho.nsa.gov, "Stephen Smalley" , "Schaufler, Casey" , "Luis R. Rodriguez" , "Dmitry Kasatkin" , "Greg Kroah-Hartman" , "Peter Jones" , "Takashi Iwai" , dwmw2@infradead.org, "Ming Lei" , "Joey Lee" , =?utf-8?B?IlZvanTEm2NoIFBhdmzDrWsi?= , "Kyle McMartin" , "Seth Forshee" , "Matthew Garrett" , "Johannes Berg" User-Agent: SquirrelMail/1.4.22-15.fc21 MIME-Version: 1.0 Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: 8bit X-Priority: 3 (Normal) Importance: Normal X-SRS-Rewrite: SMTP reverse-path rewritten from by twosheds.infradead.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1910 Lines: 53 See http://www.infradead.org/rpr.html > Luis R. Rodriguez wrote: > >> "PKCS#7: Add an optional authenticated attribute to hold firmware name" >> https://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/commit/?h=fwsign-pkcs7&id=1448377a369993f864915743cfb34772e730213good >> >> 1.3.6.1.4.1.2312.16 Linux kernel >> 1.3.6.1.4.1.2312.16.2 - PKCS#7/CMS SignerInfo attribute types >> 1.3.6.1.4.1.2312.16.2.1 - firmwareName >> >> I take it you are referring to this? > > Yes. > >> If we follow this model we'd then need something like: >> >> 1.3.6.1.4.1.2312.16.2.2 - seLinuxPolicyName >> >> That should mean each OID that has different file names would need to be >> explicit about and have a similar entry on the registry. I find that >> pretty >> redundant and would like to avoid that if possible. > > firmwareName is easy for people to understand - it's the name the kernel > asks > for and the filename of the blob. seLinuxPolicyName is, I think, a lot > more > tricky since a lot of people don't use SELinux, and most that do don't > understand it (most people that use it aren't even really aware of it). > > If you can use the firmwareName as the SELinux/LSM key, I would suggest > doing > so - even if you dress it up as a path (/lib/firmware/). > > David > In conversation with Mimi last week she was very keen on the model where we load modules & firmware in such a fashion that the kernel has access to the original inode -- by passing in a f2f, or in the firmware case by doing the rd lookup directly. So surely you have all the SELinux labelling you need? -- dwmw2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/