Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752337AbbH0LFP (ORCPT ); Thu, 27 Aug 2015 07:05:15 -0400 Received: from lucky1.263xmail.com ([211.157.147.133]:40927 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750725AbbH0LFN (ORCPT ); Thu, 27 Aug 2015 07:05:13 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: shawn.lin@rock-chips.com X-FST-TO: boojin.kim@samsung.com X-SENDER-IP: 220.200.5.186 X-LOGIN-NAME: shawn.lin@rock-chips.com X-UNIQUE-TAG: <46d915606d43b4ecde2c3cab90febd65> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH 1/5] DMA: pl330: support burst mode for dev-to-mem and mem-to-dev transmit To: Heiko Stuebner References: <1440665280-31557-1-git-send-email-shawn.lin@rock-chips.com> <1440665313-31603-1-git-send-email-shawn.lin@rock-chips.com> <7170592.bdD8VT9GQ2@phil> Cc: shawn.lin@rock-chips.com, Vinod Koul , Doug Anderson , Olof Johansson , Sonny Rao , Addy Ke , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Boojin Kim From: Shawn Lin Message-ID: <55DEEEE0.4060208@rock-chips.com> Date: Thu, 27 Aug 2015 19:05:04 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <7170592.bdD8VT9GQ2@phil> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3629 Lines: 112 On 2015/8/27 16:57, Heiko Stuebner wrote: > Hi Shawn, > > > you're loosing the original author. Your can override the patch-author (away > from the mail sender) via a "From:" line at the top of the commit message, > like: > Woops.... sorry for missing this bit. Thanks for pointing out that. :) Patch 1 is from Boojin, and patch 2,3 attribute to Addy(Actually I rebase it for linux-next from v3.14). patch 4 and 5 comes from myself. It will be fixed from the next ones if any. > ------ > From: Boojin Kim > > This patch adds to support burst mode for dev-to-mem and > mem-to-dev transmit. > ... > ------ > > >> This patch adds to support burst mode for dev-to-mem and >> mem-to-dev transmit. >> >> Signed-off-by: Boojin Kim >> Signed-off-by: Addy Ke >> Signed-off-by: Shawn Lin >> cc: Heiko Stuebner >> cc: Doug Anderson >> cc: Olof Johansson >> Reviewed-and-tested-by: Sonny Rao >> >> --- >> >> drivers/dma/pl330.c | 18 ++++++++++++------ >> 1 file changed, 12 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c >> index ecab4ea0..0d544d2 100644 >> --- a/drivers/dma/pl330.c >> +++ b/drivers/dma/pl330.c >> @@ -1141,10 +1141,13 @@ static inline int _ldst_devtomem(unsigned dry_run, >> u8 buf[], const struct _xfer_spec *pxs, int cyc) >> { >> int off = 0; >> + enum pl330_cond cond; >> + >> + cond = (pxs->desc->rqcfg.brst_len == 1) ? SINGLE : BURST; >> >> while (cyc--) { >> - off += _emit_WFP(dry_run, &buf[off], SINGLE, pxs->desc->peri); >> - off += _emit_LDP(dry_run, &buf[off], SINGLE, pxs->desc->peri); >> + off += _emit_WFP(dry_run, &buf[off], cond, pxs->desc->peri); >> + off += _emit_LDP(dry_run, &buf[off], cond, pxs->desc->peri); >> off += _emit_ST(dry_run, &buf[off], ALWAYS); >> off += _emit_FLUSHP(dry_run, &buf[off], pxs->desc->peri); >> } >> @@ -1156,11 +1159,14 @@ static inline int _ldst_memtodev(unsigned dry_run, >> u8 buf[], const struct _xfer_spec *pxs, int cyc) >> { >> int off = 0; >> + enum pl330_cond cond; >> + >> + cond = (pxs->desc->rqcfg.brst_len == 1) ? SINGLE : BURST; >> >> while (cyc--) { >> - off += _emit_WFP(dry_run, &buf[off], SINGLE, pxs->desc->peri); >> + off += _emit_WFP(dry_run, &buf[off], cond, pxs->desc->peri); >> off += _emit_LD(dry_run, &buf[off], ALWAYS); >> - off += _emit_STP(dry_run, &buf[off], SINGLE, pxs->desc->peri); >> + off += _emit_STP(dry_run, &buf[off], cond, pxs->desc->peri); >> off += _emit_FLUSHP(dry_run, &buf[off], pxs->desc->peri); >> } >> >> @@ -2557,7 +2563,7 @@ static struct dma_async_tx_descriptor >> *pl330_prep_dma_cyclic( >> >> desc->rqtype = direction; >> desc->rqcfg.brst_size = pch->burst_sz; >> - desc->rqcfg.brst_len = 1; >> + desc->rqcfg.brst_len = pch->burst_len; >> desc->bytes_requested = period_len; >> fill_px(&desc->px, dst, src, period_len); >> >> @@ -2702,7 +2708,7 @@ pl330_prep_slave_sg(struct dma_chan *chan, struct >> scatterlist *sgl, } >> >> desc->rqcfg.brst_size = pch->burst_sz; >> - desc->rqcfg.brst_len = 1; >> + desc->rqcfg.brst_len = pch->burst_len; >> desc->rqtype = direction; >> desc->bytes_requested = sg_dma_len(sg); >> } > > > > -- Best Regards Shawn Lin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/