Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753791AbbH0ON3 (ORCPT ); Thu, 27 Aug 2015 10:13:29 -0400 Received: from mail.kernel.org ([198.145.29.136]:36132 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752689AbbH0ON1 (ORCPT ); Thu, 27 Aug 2015 10:13:27 -0400 Date: Thu, 27 Aug 2015 11:13:23 -0300 From: Arnaldo Carvalho de Melo To: Yannick Brosseau Cc: ak@linux.intel.com, jolsa@kernel.org, linux-kernel@vger.kernel.org, Mark Drayton Subject: Re: [PATCH] perf script: Add --[no-]-demangle/--[no-]-demangle-kernel Message-ID: <20150827141323.GA31339@kernel.org> References: <1440616695-32340-1-git-send-email-scientist@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1440616695-32340-1-git-send-email-scientist@fb.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2418 Lines: 63 Em Wed, Aug 26, 2015 at 12:18:15PM -0700, Yannick Brosseau escreveu: > From: Mark Drayton > > Summary: Sometimes when post-processing output from `perf script` one > does not want to demangle C++ symbol names. Add an option to allow this. > Also add --[no-]demangle-kernel to be consistent with top/report/probe. > > Signed-off-by: Mark Drayton > Signed-off-by: Yannick Brosseau Thanks, applied after fixing up it wrt other changes in builtin-script.c, next time, for new features like this, make sure it applies to my perf/core branch at: git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git - Arnaldo > --- > tools/perf/Documentation/perf-script.txt | 7 +++++++ > tools/perf/builtin-script.c | 4 ++++ > 2 files changed, 11 insertions(+) > > diff --git a/tools/perf/Documentation/perf-script.txt b/tools/perf/Documentation/perf-script.txt > index c82df57..347c73a 100644 > --- a/tools/perf/Documentation/perf-script.txt > +++ b/tools/perf/Documentation/perf-script.txt > @@ -222,6 +222,13 @@ OPTIONS > --show-mmap-events > Display mmap related events (e.g. MMAP, MMAP2). > > +--demangle:: > + Demangle symbol names to human readable form. It's enabled by default, > + disable with --no-demangle. > + > +--demangle-kernel:: > + Demangle kernel symbol names to human readable form (for C++ kernels). > + > --header > Show perf.data header. > > diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c > index 24809787..f3b3ba0 100644 > --- a/tools/perf/builtin-script.c > +++ b/tools/perf/builtin-script.c > @@ -1622,6 +1622,10 @@ int cmd_script(int argc, const char **argv, const char *prefix __maybe_unused) > OPT_CALLBACK_OPTARG(0, "itrace", &itrace_synth_opts, NULL, "opts", > "Instruction Tracing options", > itrace_parse_synth_opts), > + OPT_BOOLEAN(0, "demangle", &symbol_conf.demangle, > + "Enable symbol demangling"), > + OPT_BOOLEAN(0, "demangle-kernel", &symbol_conf.demangle_kernel, > + "Enable kernel symbol demangling"), > OPT_END() > }; > const char * const script_subcommands[] = { "record", "report", NULL }; > -- > 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/