Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754435AbbH0PtI (ORCPT ); Thu, 27 Aug 2015 11:49:08 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:33331 "EHLO mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754299AbbH0PtF (ORCPT ); Thu, 27 Aug 2015 11:49:05 -0400 Date: Thu, 27 Aug 2015 17:49:02 +0200 From: Luis de Bethencourt To: Bin Liu Cc: linux-kernel@vger.kernel.org, Felipe Balbi , Greg Kroah-Hartman , linux-usb@vger.kernel.org Subject: Re: [PATCH] usb: musb: Fix module autoload for OF platform driver Message-ID: <20150827154902.GA2117@goodgumbo.baconseed.org> References: <20150827150757.GA390@goodgumbo.baconseed.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1889 Lines: 57 On Thu, Aug 27, 2015 at 10:41:42AM -0500, Bin Liu wrote: > Hi, > > On Thu, Aug 27, 2015 at 10:07 AM, Luis de Bethencourt > wrote: > > This platform driver has a OF device ID table but the OF module > > alias information is not created so module autoloading won't work. > > Care to add 'ux500' to the summary line - 'usb: musb: ux500: Fix...'? > That helps filtering in git-log. > > Thanks, > -Bin. > Off course. Sent a second version with 'usb: musb: ux500:' in the commit subject. Thanks for reviewing, Luis > > > > Signed-off-by: Luis de Bethencourt > > --- > > drivers/usb/musb/ux500.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/usb/musb/ux500.c b/drivers/usb/musb/ux500.c > > index 39168fe..b2685e7 100644 > > --- a/drivers/usb/musb/ux500.c > > +++ b/drivers/usb/musb/ux500.c > > @@ -379,6 +379,8 @@ static const struct of_device_id ux500_match[] = { > > {} > > }; > > > > +MODULE_DEVICE_TABLE(of, ux500_match); > > + > > static struct platform_driver ux500_driver = { > > .probe = ux500_probe, > > .remove = ux500_remove, > > -- > > 2.4.6 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/