Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754770AbbH0QcF (ORCPT ); Thu, 27 Aug 2015 12:32:05 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:53921 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752756AbbH0QcC (ORCPT ); Thu, 27 Aug 2015 12:32:02 -0400 Date: Thu, 27 Aug 2015 11:32:00 -0500 From: Andy Gross To: Stanimir Varbanov Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bjorn Andersson Subject: Re: [PATCH v2] soc: qcom: smd: Use correct remote processor ID Message-ID: <20150827163200.GB13642@qualcomm.com> References: <1440618165-9410-1-git-send-email-agross@codeaurora.org> <55DF2C35.4030207@mm-sol.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55DF2C35.4030207@mm-sol.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2091 Lines: 52 On Thu, Aug 27, 2015 at 06:26:45PM +0300, Stanimir Varbanov wrote: > On 08/26/2015 10:42 PM, Andy Gross wrote: > > This patch fixes SMEM addressing issues when remote processors need to use > > secure SMEM partitions. > > > > Signed-off-by: Andy Gross > > --- > > .../devicetree/bindings/soc/qcom/qcom,smd.txt | 6 ++++++ > > drivers/soc/qcom/smd.c | 15 +++++++++++---- > > 2 files changed, 17 insertions(+), 4 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,smd.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,smd.txt > > index f65c76d..97d9b3e 100644 > > --- a/Documentation/devicetree/bindings/soc/qcom/qcom,smd.txt > > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,smd.txt > > @@ -37,6 +37,12 @@ The edge is described by the following properties: > > Definition: the identifier of the remote processor in the smd channel > > allocation table > > > > +- qcom,remote-pid: > > + Usage: optional > > + Value type: > > + Definition: the identifier for the remote processor as known by the rest > > + of the system. > > + > > = SMD DEVICES > > > > In turn, subnodes of the "edges" represent devices tied to SMD channels on that > > diff --git a/drivers/soc/qcom/smd.c b/drivers/soc/qcom/smd.c > > index 327adcf..5706a81 100644 > > --- a/drivers/soc/qcom/smd.c > > +++ b/drivers/soc/qcom/smd.c > > @@ -111,6 +111,7 @@ struct qcom_smd_edge { > > struct qcom_smd *smd; > > struct device_node *of_node; > > unsigned edge_id; > > + unsigned remote_pid; > > Andy, you forgot to add this new field in structure description header. Good catch. Thanks! -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/