Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752378AbbH0SKU (ORCPT <rfc822;w@1wt.eu>);
	Thu, 27 Aug 2015 14:10:20 -0400
Received: from lists.s-osg.org ([54.187.51.154]:60541 "EHLO lists.s-osg.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751700AbbH0SKS (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 27 Aug 2015 14:10:18 -0400
Subject: Re: [PATCH v3] selftests/zram: Adding zram tests
To: naresh.kamboju@linaro.org, linux-kernel@vger.kernel.org
References: <1439881319-9727-1-git-send-email-naresh.kamboju@linaro.org>
Cc: tyler.baker@linaro.org, milosz.wasilewski@linaro.org,
        alexey.kodanev@oracle.com, Shuah Khan <shuahkh@osg.samsung.com>
From: Shuah Khan <shuahkh@osg.samsung.com>
X-Enigmail-Draft-Status: N1110
Organization: Samsung Open Source Group
Message-ID: <55DF5288.4040405@osg.samsung.com>
Date: Thu, 27 Aug 2015 12:10:16 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <1439881319-9727-1-git-send-email-naresh.kamboju@linaro.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1655
Lines: 45

On 08/18/2015 01:01 AM, naresh.kamboju@linaro.org wrote:
> From: Naresh Kamboju <naresh.kamboju@linaro.org>
> 
> zram: Compressed RAM based block devices
> ----------------------------------------
> The zram module creates RAM based block devices named /dev/zram<id>
> (<id> = 0, 1, ...). Pages written to these disks are compressed and stored
> in memory itself. These disks allow very fast I/O and compression provides
> good amounts of memory savings. Some of the usecases include /tmp storage,
> use as swap disks, various caches under /var and maybe many more :)
> 
> Statistics for individual zram devices are exported through sysfs nodes at
> /sys/block/zram<id>/
> 
> This patch is to validate the zram functionality. Test interacts with block
> device /dev/zram<id> and sysfs nodes /sys/block/zram<id>/
> 

Hi Naresh,

This doesn't fail gracefully when a regular user runs it. Please add
a check for root and make the test fail gracefully when a non-root
user runs it.

Please refer to tools/testing/selftests/efivarfs/efivarfs.sh
for an example on how to check for root.

I was getting ready to apply this to linux-kselftest next for 4.3
and ran some sanity tests. If you get me new revision quickly
I can get it into 4.3-rc1.

thanks,
-- Shuah

-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/