Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752860AbbH0Si0 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 27 Aug 2015 14:38:26 -0400
Received: from shards.monkeyblade.net ([149.20.54.216]:45680 "EHLO
	shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751186AbbH0SiZ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 27 Aug 2015 14:38:25 -0400
Date: Thu, 27 Aug 2015 11:38:23 -0700 (PDT)
Message-Id: <20150827.113823.214019265460582055.davem@davemloft.net>
To: raghavendra.kt@linux.vnet.ibm.com
Cc: kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org,
        kaber@trash.net, jiri@resnulli.us, edumazet@google.com,
        hannes@stressinduktion.org, tom@herbertland.com, azhou@nicira.com,
        ebiederm@xmission.com, ipm@chirality.org.uk, nicolas.dichtel@6wind.com,
        serge.hallyn@canonical.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, anton@au1.ibm.com,
        nacc@linux.vnet.ibm.com, srikar@linux.vnet.ibm.com
Subject: Re: [PATCH RFC V2 2/2] net: Optimize snmp stat aggregation by
 walking all the percpu data at once
From: David Miller <davem@davemloft.net>
In-Reply-To: <1440610653-14210-3-git-send-email-raghavendra.kt@linux.vnet.ibm.com>
References: <y>
	<1440610653-14210-1-git-send-email-raghavendra.kt@linux.vnet.ibm.com>
	<1440610653-14210-3-git-send-email-raghavendra.kt@linux.vnet.ibm.com>
X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 27 Aug 2015 11:38:24 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 807
Lines: 22

From: Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>
Date: Wed, 26 Aug 2015 23:07:33 +0530

> @@ -4641,10 +4647,12 @@ static inline void __snmp6_fill_stats64(u64 *stats, void __percpu *mib,
>  static void snmp6_fill_stats(u64 *stats, struct inet6_dev *idev, int attrtype,
>  			     int bytes)
>  {
> +	u64 buff[IPSTATS_MIB_MAX] = {0,};
> +
>  	switch (attrtype) {
>  	case IFLA_INET6_STATS:
> -		__snmp6_fill_stats64(stats, idev->stats.ipv6,

I would suggest using an explicit memset() here, it makes the overhead incurred
by this scheme clearer.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/