Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752771AbbH0TEa (ORCPT ); Thu, 27 Aug 2015 15:04:30 -0400 Received: from g9t5009.houston.hp.com ([15.240.92.67]:38377 "EHLO g9t5009.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751728AbbH0TE3 (ORCPT ); Thu, 27 Aug 2015 15:04:29 -0400 Message-ID: <1440702140.14237.92.camel@hp.com> Subject: Re: [PATCH 1/2]: nfit: Clarify memory device state flags strings From: Toshi Kani To: Dan Williams Cc: Rafael J Wysocki , Robert Moore , "linux-nvdimm@lists.01.org" , Linux ACPI , "linux-kernel@vger.kernel.org" , "Elliott, Robert (Server Storage)" Date: Thu, 27 Aug 2015 13:02:20 -0600 In-Reply-To: References: <1440606024-29873-1-git-send-email-toshi.kani@hp.com> <1440606024-29873-2-git-send-email-toshi.kani@hp.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.4 (3.16.4-2.fc22) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2193 Lines: 44 On Thu, 2015-08-27 at 11:57 -0700, Dan Williams wrote: > On Wed, Aug 26, 2015 at 9:20 AM, Toshi Kani wrote: > > ACPI 6.0 NFIT Memory Device State Flags in Table 5-129 defines > > NVDIMM status as follows. These bits indicate multiple info, > > such as failures, pending event, and capability. > > > > Bit [0] set to 1 to indicate that the previous SAVE to the > > Memory Device failed. > > Bit [1] set to 1 to indicate that the last RESTORE from the > > Memory Device failed. > > Bit [2] set to 1 to indicate that platform flush of data to > > Memory Device failed. As a result, the restored data content > > may be inconsistent even if SAVE and RESTORE do not indicate > > failure. > > Bit [3] set to 1 to indicate that the Memory Device is observed > > to be not armed prior to OSPM hand off. A Memory Device is > > considered armed if it is able to accept persistent writes. > > Bit [4] set to 1 to indicate that the Memory Device observed > > SMART and health events prior to OSPM handoff. > > Bit [5] is set to 1 to indicate that platform firmware is > > enabled to notify OSPM on SMART and health events related to > > the memory device using Notify codes as specified in Section > > 5.6.6. > > > > /sys/bus/nd/devices/nmemX/nfit/flags shows this flags info. > > The output strings associated with the bits are "save", "restore", > > "smart", etc., which can be confusing as they may be interpreted > > as positive status, i.e. save succeeded. > > > > Change the strings to be more descriptive per the ACPI spec. > > Also add a string to bit 5 for completeness. > > Ok I'm going to push this upstream for 4.2 with the "not_armed" fixup > that Ross suggested, but I'll defer adding bit5 since that is separate > from the urgent fix to get the polarities properly reflected and we > can add support for it later. Great!! Thanks Dan! (and sorry for making more work to you...) -Toshi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/