Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751797AbbH0T4N (ORCPT ); Thu, 27 Aug 2015 15:56:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43172 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751000AbbH0T4L (ORCPT ); Thu, 27 Aug 2015 15:56:11 -0400 Subject: Re: [scsi 5/7 RESEND] scsi_debug: schedule_resp fix input variable check From: Ewan Milne Reply-To: emilne@redhat.com To: James Bottomley Cc: "Winkler, Tomas" , Christoph Hellwig , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Douglas Gilbert In-Reply-To: <1440632280.2196.94.camel@HansenPartnership.com> References: <1438091666-18113-1-git-send-email-tomas.winkler@intel.com> <1438091666-18113-5-git-send-email-tomas.winkler@intel.com> <1440532371.23183.81.camel@localhost.localdomain> <5B8DA87D05A7694D9FA63FD143655C1B3D42E9D0@hasmsx108.ger.corp.intel.com> <1440632280.2196.94.camel@HansenPartnership.com> Content-Type: text/plain; charset="UTF-8" Organization: Red Hat Date: Thu, 27 Aug 2015 15:56:09 -0400 Message-ID: <1440705369.23183.142.camel@localhost.localdomain> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1924 Lines: 57 On Wed, 2015-08-26 at 16:38 -0700, James Bottomley wrote: > On Tue, 2015-08-25 at 21:03 +0000, Winkler, Tomas wrote: > > > > > > + /* this should never happen */ > > > > + if (WARN_ON(!cmnd)) > > > > + return SCSI_MLQUEUE_HOST_BUSY; > > > > > > > > - if (NULL == cmnd || NULL == devip) { > > > > - pr_warn("called with NULL cmnd or devip pointer\n"); > > > > + if (NULL == devip) { > > > > + pr_warn("called devip == NULL\n"); > > > > /* no particularly good error to report back */ > > > > return SCSI_MLQUEUE_HOST_BUSY; > > > > } > > > > > > Please refer to the patch I just posted, we can't return _HOST_BUSY here > > > if devip == NULL. I posted a fix against the current "misc" branch as > > > I don't see this patch applied, let me know if I need to update it. > > > > > > I'm just not sure why the patches are not merged or even rejected. > > Because ideally I want a Maintainer ack. That's Doug Gilbert. > > > I'm submitting patches to the Linux kernel for more than 10 years to > > various trees and I can agree that these are not some urgent fixes, > > but this is the first time my effort is ignored for such long time by > > the maintainer. > > Well, OK, I trust martin, I'll override the lack of Maintainer ack if > you fix as Ewan suggests. > Just to clarify, I didn't have a problem with Tomas' patch per se, it's just that my patch won't apply on top of his. I'll submit a v2 if you want, so you can apply Tomas' patch first. The problem I'm fixing has been in there for a while. Let me know if you want me to do that. -Ewan > James > > > > Thanks > > Tomas > > > > NrybXǧv^)޺{.n+{"{ayʇڙ,jfhzw j:+vwjmzZ+ݢj"! > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/