Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933133AbbH0WrY (ORCPT ); Thu, 27 Aug 2015 18:47:24 -0400 Received: from mail-wi0-f173.google.com ([209.85.212.173]:35865 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757297AbbH0WrW (ORCPT ); Thu, 27 Aug 2015 18:47:22 -0400 Date: Thu, 27 Aug 2015 23:47:19 +0100 From: Matt Fleming To: Jiri Olsa Cc: Arnaldo Carvalho de Melo , lkml , David Ahern , Ingo Molnar , Namhyung Kim , Peter Zijlstra , =?iso-8859-1?Q?Rapha=EBl?= Beamonte Subject: Re: [PATCH 02/11] perf tools: Add tracing_path and remove unneeded functions Message-ID: <20150827224719.GE3596@codeblueprint.co.uk> References: <1440596813-12844-1-git-send-email-jolsa@kernel.org> <1440596813-12844-3-git-send-email-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1440596813-12844-3-git-send-email-jolsa@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 864 Lines: 20 On Wed, 26 Aug, at 03:46:44PM, Jiri Olsa wrote: > There's no need for find_tracing_dir, because perf already > searches for debugfs/tracefs mount on start and populate > tracing_events_path. I'm getting a bit lost searching through the git history of these functions. Why is it safe to delete these functions? Where did the old user that required find_tracing_dir() to mount debugfs disappear to? The code to do the mount of debugfs/tracefs when perf starts appears to have been around for years. Is the mounting operation of find_tracing_dir() just dead code? -- Matt Fleming, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/