Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752275AbbH0Xwb (ORCPT ); Thu, 27 Aug 2015 19:52:31 -0400 Received: from lucky1.263xmail.com ([211.157.147.133]:55988 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751606AbbH0Xw2 (ORCPT ); Thu, 27 Aug 2015 19:52:28 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: shawn.lin@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: shawn.lin@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v1 3/5] ARM: dts: Add arm, pl330-broken-no-flushp quirk for rk3288 platform To: Doug Anderson References: <1440685419-22037-1-git-send-email-shawn.lin@rock-chips.com> <1440685481-22163-1-git-send-email-shawn.lin@rock-chips.com> Cc: shawn.lin@rock-chips.com, Vinod Koul , Heiko Stuebner , Addy Ke , Boojin Kim , Olof Johansson , "linux-kernel@vger.kernel.org" , "open list:ARM/Rockchip SoC..." , dmaengine@vger.kernel.org, Sonny Rao , "linux-arm-kernel@lists.infradead.org" From: Shawn Lin Message-ID: <55DFA2B3.1010401@rock-chips.com> Date: Fri, 28 Aug 2015 07:52:19 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2685 Lines: 89 On 2015/8/28 0:52, Doug Anderson wrote: > Hi, > > On Thu, Aug 27, 2015 at 7:24 AM, Shawn Lin wrote: >> From: Addy Ke > > Looks like you just added the "From" here. I think that's fine, but > better to set the author so you get the right cover letter... > > >> Pl330 integrated in rk3288 platform doesn't support >> DMAFLUSHP function. So we add broken-no-flushp quirk >> for it. >> >> Signed-off-by: Addy Ke >> Signed-off-by: Shawn Lin >> cc: Heiko Stuebner >> cc: Doug Anderson >> cc: Olof Johansson >> >> --- >> >> Changes in v1: >> - rename broken-no-flushp to "arm,pl330-broken-no-flushp" suggested >> by Krzysztof. >> - remove Sunny's tag > > Note that typically for patches I see people go from "no v" to "v2". AKA: > * PATCH > * PATCH v2 > * PATCH v3 > > >> arch/arm/boot/dts/rk3288.dtsi | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi >> index 22316d0..106adf7 100644 >> --- a/arch/arm/boot/dts/rk3288.dtsi >> +++ b/arch/arm/boot/dts/rk3288.dtsi >> @@ -144,6 +144,7 @@ >> #dma-cells = <1>; >> clocks = <&cru ACLK_DMAC2>; >> clock-names = "apb_pclk"; >> + arm,pl330-broken-no-flushp; > > Note that you should add bindings _before_ the usage of them. So > patch #5 (Documentation) needs to come before this one. > Cool! That makes sense. Thanks, Doug. >> }; >> >> dmac_bus_ns: dma-controller@ff600000 { >> @@ -155,6 +156,7 @@ >> clocks = <&cru ACLK_DMAC1>; >> clock-names = "apb_pclk"; >> status = "disabled"; >> + arm,pl330-broken-no-flushp; >> }; >> >> dmac_bus_s: dma-controller@ffb20000 { >> @@ -165,6 +167,7 @@ >> #dma-cells = <1>; >> clocks = <&cru ACLK_DMAC1>; >> clock-names = "apb_pclk"; >> + arm,pl330-broken-no-flushp; >> }; >> }; > > Other than the small nits above, this looks fine to me. > > Reviewed-by: Douglas Anderson > > > -- Best Regards Shawn Lin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/