MIME-Version: 1.0
In-Reply-To: <CAGk-QBvVXmviuM4i6TzBqGV8q+1H4pOa8mMn3DreYMPytRwWag@mail.gmail.com>
References: <CAGk-QBt147T_A-BuPn1M2rHkQaCn0_RXgZvx3Zbf9L3_7CDQtQ@mail.gmail.com>
	<20150824125902.4ba11ec6@gandalf.local.home>
	<CAGk-QBtw2Z_-8sfv7y--zmu-f1HdOsK=xiZGFhuQ7z_zJBtXGw@mail.gmail.com>
	<9CF68C3D-499C-4AFC-B890-BA5ECA284347@xmission.com>
	<CAGk-QBsNhHH5p4PrG3-sCjKGaUbv1cQ8vAJmdQKVF2iFCbt0+g@mail.gmail.com>
	<20150825101507.4e3be4ca@gandalf.local.home>
	<CAGk-QBsHeddJ3Ywu+6GM6=4iL8E+M97i-KgCEYWRFPM+tfQZMA@mail.gmail.com>
	<55DCA705.8000903@gmail.com>
	<20150825150536.546a73e5@gandalf.local.home>
	<CAGk-QBte6bWGWWYGy=UmyqFuchy_94pr2o7B9p1tK=dgU+CK1Q@mail.gmail.com>
	<20150826163621.28d7990a@gandalf.local.home>
	<CAGk-QBtv5a4+x=XAi5TE+icUjuiZwnZNkfMvcAAOOOCt=uRzGw@mail.gmail.com>
	<20150826223230.4348d936@grimm.local.home>
	<CAGk-QBvVXmviuM4i6TzBqGV8q+1H4pOa8mMn3DreYMPytRwWag@mail.gmail.com>
Date: Fri, 28 Aug 2015 11:31:54 +0800
Message-ID: <CAGk-QBtmbkVukWO-kSxUEj_nyZHnxho-RfHRoH_PgcPRdmZxDA@mail.gmail.com>
Subject: Re: [PATCH] kernel/sysctl.c: If "count" including the terminating
 byte '\0' the write system call should retrun success.
From: Sean Fu <fxinrong@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Austin S Hemmelgarn <ahferroin7@gmail.com>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        Andrey Ryabinin <ryabinin.a.a@gmail.com>,
        Ulrich Obergfell <uobergfe@redhat.com>,
        Prarit Bhargava <prarit@redhat.com>,
        Eric B Munson <emunson@akamai.com>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Thomas Gleixner <tglx@linutronix.de>, Don Zickus <dzickus@redhat.com>,
        Heinrich Schuchardt <xypron.glpk@gmx.de>,
        David Rientjes <rientjes@google.com>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1663
Lines: 46

On Thu, Aug 27, 2015 at 4:32 PM, Sean Fu <fxinrong@gmail.com> wrote:
> On Thu, Aug 27, 2015 at 10:32 AM, Steven Rostedt <rostedt@goodmis.org> wrote:
>> On Thu, 27 Aug 2015 08:17:29 +0800
>> Sean Fu <fxinrong@gmail.com> wrote:
>>
>>> On Thu, Aug 27, 2015 at 4:36 AM, Steven Rostedt <rostedt@goodmis.org> wrote:
>>> > On Wed, 26 Aug 2015 23:48:01 +0800
>>> > Sean Fu <fxinrong@gmail.com> wrote:
>>> >
>>> >
>>> >> > Defending the patch, I can't imagine any user space code expecting the
>>> >> > current behavior. The current behavior is that if you write "1\0" it
>>> >> > will error out instead of accepting the "1". I can't come up with a
>>> >> > scenario that would require userspace to expect "1\0" to fail. Can you?
>>> >> Thanks
>>> >
>>> > Although, with the current patch, would "1\02" fail? It should.
>>> Yes, "1\02" is equal to "1\2"(count=2) or "1\2\0"(count=3), So it should fail.
>>
>> Sorry, I meant "1\0 2"
> In this case, The patch behavior is accepting the "1" and discarding
> other bytes.
> for (; left && vleft--; i++, first=0) {    //vleft is 1 for integer
> type or unsigned long type proc file
>
>>
>> -- Steve
>>
>>>
>>> code
>>> len = write(fd, "1\0\2", 3);
>>>
>>> strace execute result:
>>> write(3, "1\2\0", 3)                    = -1 EINVAL (Invalid argument)
If vleft > 1, "1\0 2" is treated as invalid paraments and all string
include '\0' will be invalid.

>>>
>>> >
>>> > -- Steve
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/