Message-ID: <1440739104.26094.1.camel@freescale.com>
Subject: Re: [PATCH v2,2/5] powerpc/rcpm: add RCPM driver
From: Scott Wood <scottwood@freescale.com>
To: Chenhui Zhao <chenhui.zhao@freescale.com>
CC: <linuxppc-dev@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>,
        <Jason.Jin@freescale.com>
Date: Fri, 28 Aug 2015 00:18:24 -0500
In-Reply-To: <1440722422.31670.0@remotesmtp.freescale.net>
References: <1440590988-25594-1-git-send-email-chenhui.zhao@freescale.com>
	 <1440590988-25594-2-git-send-email-chenhui.zhao@freescale.com>
	 <20150826203539.GA10582@home.buserror.net>
	 <1440722422.31670.0@remotesmtp.freescale.net>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2015 05:18:34.1516
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB1477
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1362
Lines: 36

On Fri, 2015-08-28 at 08:40 +0800, Scott Wood wrote:
> On Thu, Aug 27, 2015 at 4:35 AM, Scott Wood <scottwood@freescale.com> 
> wrote:
> > On Wed, Aug 26, 2015 at 08:09:45PM +0800, Chenhui Zhao wrote:

I didn't write this e-mail.  Please fix your mail client.

> > >  +static void rcpm_v1_cpu_up_prepare(int cpu)
> > >  +{
> > >  +        rcpm_v1_cpu_exit_state(cpu, E500_PM_PH15);
> > >  +        rcpm_v1_irq_unmask(cpu);
> > >  +}
> > >  +
> > >  +static void rcpm_v2_cpu_exit_state(int cpu, int state)
> > >  +{
> > >  +        int hw_cpu = get_hard_smp_processor_id(cpu);
> > >  +        u32 mask = 1 << cpu_core_index_of_thread(hw_cpu);
> > 
> > Are you sure cpu_core_index_of_thread() is supposed to take a hardware
> > cpu id?  The only current user, pseries_energy.c, has the comment
> > "Convert logical cpu number to core number".
> 
> Here, the method of getting core index of thread is same for physical 
> and logical.
> So use this existed function to do the job.

I realize that you get the same result either way, but that doesn't make it 
OK.  You have "cpu"; pass that instead of "hw_cpu".

-Scott

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/