Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752002AbbH1IWf (ORCPT ); Fri, 28 Aug 2015 04:22:35 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:36645 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751313AbbH1IWb (ORCPT ); Fri, 28 Aug 2015 04:22:31 -0400 Message-ID: <55E01A43.9080109@roeck-us.net> Date: Fri, 28 Aug 2015 01:22:27 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Ingo Molnar , "Luis R. Rodriguez" CC: schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, linux-s390@vger.kernel.org, bp@suse.de, plagnioj@jcrosoft.com, tomi.valkeinen@ti.com, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, fengguang.wu@intel.com, akpm@linux-foundation.org, rostedt@goodmis.org, "Luis R. Rodriguez" Subject: Re: [PATCH] S390: add pci_iomap_wc() and pci_iomap_wc_range() References: <1440632050-23648-1-git-send-email-mcgrof@do-not-panic.com> <20150828060605.GF26741@gmail.com> In-Reply-To: <20150828060605.GF26741@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1914 Lines: 53 On 08/27/2015 11:06 PM, Ingo Molnar wrote: > > * Luis R. Rodriguez wrote: > >> From: "Luis R. Rodriguez" >> >> S390 requires its own implementation of pcio_iomap*() calls >> is because it has its "BAR spaces are not disjunctive on s390 >> so we need the bar parameter of pci_iomap to find the corresponding >> device and create the mapping cookie" -- in summary, it has its own >> lookup/lock solution. >> >> It does not include asm-generic/pci_iomap.h >> >> Since it currenty maps ioremap_wc() to ioremap_nocache() and that's >> the architecture default we can easily just map the wc calls to >> the default calls as well. >> >> Cc: Guenter Roeck >> Cc: Jean-Christophe Plagniol-Villard >> Cc: Tomi Valkeinen >> Cc: linux-fbdev@vger.kernel.org >> Cc: linux-kernel@vger.kernel.org >> Cc: Borislav Petkov >> Cc: Ingo Molnar >> Cc: Fengguang Wu >> Cc: Andrew Morton >> Cc: Steven Rostedt >> Reported-by: 0 day bot >> Signed-off-by: Luis R. Rodriguez >> --- >> >> This broke through some series that went into Ingo's tip tree which >> I added. As such I *think* this should go through Ingo's tip tree. >> Let me know. Up to you guys. > > I fixed the changelog to explain all this. > > Also, is there any other architecture that got broken by: > > 1b3d4200c1e0 PCI: Add pci_iomap_wc() variants > Should be the only one. There are only two implementations of pci_iomap(), one in s390 code and the generic implementation. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/