Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751991AbbH1KUL (ORCPT ); Fri, 28 Aug 2015 06:20:11 -0400 Received: from mail-bn1bon0073.outbound.protection.outlook.com ([157.56.111.73]:59907 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751821AbbH1KUE (ORCPT ); Fri, 28 Aug 2015 06:20:04 -0400 Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=amd.com; alien8.de; dkim=none (message not signed) header.d=none;alien8.de; dmarc=permerror action=none header.from=amd.com; X-WSS-ID: 0NTSFD8-07-MKF-02 X-M-MSG: Date: Fri, 28 Aug 2015 18:18:33 +0800 From: Huang Rui To: Ingo Molnar CC: Borislav Petkov , Borislav Petkov , Jean Delvare , Guenter Roeck , Andy Lutomirski , Andreas Herrmann , Thomas Gleixner , Peter Zijlstra , "Rafael J. Wysocki" , Len Brown , John Stultz , =?iso-8859-1?Q?Fr=E9d=E9ric?= Weisbecker , "lm-sensors@lm-sensors.org" , "linux-kernel@vger.kernel.org" , "x86@kernel.org" , Andreas Herrmann , "Gopalakrishnan, Aravind" , Fengguang Wu , Aaron Lu , "Li, Tony" Subject: Re: [PATCH 09/15] x86, amd: add accessor for number of cores per compute unit Message-ID: <20150828101833.GA4191@hr-slim.amd.com> References: <1440662866-28716-1-git-send-email-ray.huang@amd.com> <1440662866-28716-10-git-send-email-ray.huang@amd.com> <20150828064814.GB20153@nazgul.tnic> <20150828080418.GB13309@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20150828080418.GB13309@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.221;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(428002)(3050300001)(189002)(164054003)(24454002)(199003)(4001350100001)(23726002)(101416001)(50986999)(64706001)(106466001)(105586002)(2950100001)(5003600100002)(54356999)(87936001)(4001540100001)(97756001)(53416004)(76176999)(86362001)(97736004)(46406003)(92566002)(5001860100001)(5007970100001)(77156002)(62966003)(50466002)(33656002)(110136002)(77096005)(47776003)(68736005)(93886004)(189998001)(5001830100001)(83506001)(19580405001)(19580395003)(46102003);DIR:OUT;SFP:1101;SCL:1;SRVR:BN4PR12MB0852;H:atltwp01.amd.com;FPR:;SPF:None;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN4PR12MB0852;2:2a1ygc0X1IY6hE3HPFuuABxRWTjAhwOYfdBltzGgMjamIp+KOSKMQ419z4U8v3A7Nvb1C7Xvesp0u50nXkq842HjYsoUQYkVtPCLWCJlqq6VABlALvgsoq/VLj8W6H7aEsYzQtit1NZSI49jsvRJmLtP92bLlnEJ6DWcNac+ALY=;3:II20A3yeNKYFEOfi2vNLXmTPZCl8MfGKj7fPc36yxJ8zXOaZHxA38yEkLrEuMcLj9L4VwgziS4O3o9IZVCl1Q4q98HHOz1vrELdHS4RUtmNKQV1a8cgXEfAVKnOCOzIatvFVngKl9llHM7YOt0yprTYu5S+DWI8KSvx2xPnl6UZOAMNdufh6LbuqmU/fAGyNJpelKBp81JuhivyDBOQ4OMMVdPtl6wvKz6SCPYV/vRHUFzHu0XdbtzJbsQVxm/e4;25:W31oOHGFNT+aSRGmpYNOkofW8lR0dQb3ZoCcprtojJREwOacIb7jqDEsT0NR30u9VlSr5IKZXGx0VSx4FHs0/f2MJCHSqtuQpKsRJF0acJYqiyZJuPAfDGIDodYBOu/7azLaL98571CpTgJGy7VfG07O6nFwGnVoM+t1z0o+Qrv5cgKDwex+Uyju112pICuDk/G5SMs5qbyB+0S78wURYVihELj8DqxcShAZIdCMkKZA1gFzM6GdItNzLzwTSmHe X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN4PR12MB0852; X-Microsoft-Exchange-Diagnostics: 1;BN4PR12MB0852;20:FS2Dqc8TvRoZ6l0ch/iGRxfMALOavegWMIEUJlkAOOVIFPbiUbU54T7ASLz8fyNkEYhl6j47URVcFU0kkYXPIPxOsksQRGh1kowsi1eFu91o+Rp2yoUE6w/l2DtcfwM99uDk1j4MJUfLTeCR9Fj3dbqZiHjS2hfFzwUXwhi3iXOhlSTL7RjLPTGjAExpd5JR9w7sJPefAwg/N6ikhEZG+rH1gpJLrXAjx73amsw3/9TCqmxllJ73PaKjUZqVuQqtixLtixX/1yQ/xFfO/xPiqJ/rHKnbkQxJrqY8uHrWMGNuqxtIdcGYXRwNNhoDWp3VM1LC5/0g2arbFzIJkxUsatZS0E/EZ7A7l6WlPDrXovFWVgu5KSgSW3/JEytMc9de6yr+urQHbxZrI/Nxu7yLQ5tOOWjzCIUwGhPXm5SuqS9iHlmG4qv5Kv5NAM3dvzYn4w/qbzSi1X6NHrKTkh6Jkt+9jgAJ3T28XxZUsV2jYfgQCk4UFX4hc0i56hLyiEDx;4:5z0C5dWUooFZyCg8w4Pba0ycZnWrqAJtQLXSuNALp7ElKLJuIMB72SJJ801S6akgls3DihiqSKyXpoOKDCQkuauG6yeH41krOrOibKfm7IMo39F8fgWGo0wrzfI87FyOluxemfY+sr1QqyJY5GsbpIulgLALUW+03Tro5w72E+to3UKyZsG3mLX8BUq13edjUUo9u3zSlb7msyh9sy5WiDv1ZS8L9rJS8a4Php5vWgvzzlFGGAhUs6IO1MnuC7ltqAYmVrTyAhFCtIb8JnPLIOzVx0jVuEthBo839P+hVgXhetzBt2iYsF4eGkE4KT7u X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(8121501046)(3002001);SRVR:BN4PR12MB0852;BCL:0;PCL:0;RULEID:;SRVR:BN4PR12MB0852; X-Forefront-PRVS: 0682FC00E8 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN4PR12MB0852;23:ul3eC16+ctNAnCXIN90a5Fy15HMiZLgPMICD+WnfD?= =?us-ascii?Q?YJwKzgwgvyoYXhx0yH2yxsmChydFAHBKuI/WpjQ5REpZYYkuNTx8BXUaGxIk?= =?us-ascii?Q?CwyYrsQVoisr8ELApzEEPOPVAxDGAT0EYzSZOtWA6XDEaF3CWndB/U3qGaPD?= =?us-ascii?Q?5c9aV3bSGok+/k2fnGRrwjfqhObh2lLA3OqEXJDJa0LOa/6ifbyTB4r7dzoO?= =?us-ascii?Q?zHB8dY/bc9OyUqrDlD/dzTReo9HMKeGru6/t3O5J324qMVhAkVO95X/qBGKe?= =?us-ascii?Q?r5M7EFf+CSDIbnyG/neXzRd+G3DUBqEPA3F3b+8f6UoOZwcAjM04cLsZxDRD?= =?us-ascii?Q?fExjmnVRdPzJYmj3QDnTcVnX9kiZP4leLec+nEXYi2GrP6RkVTbl2iQCUjDd?= =?us-ascii?Q?PaE3ke2/778Ru70tdXufYv3CGoqOaP6e/qSimHN/k/+stKZ40mj/lT40wyoD?= =?us-ascii?Q?RmTdVkFRwSAdQaPbnmpJ3YtUQXKvvH0PoK/49xe4yTLMa0JmMLDTnTbczL8t?= =?us-ascii?Q?IjGU8NRR4bd7C8+FFnQ2fKCtDc5lonKIvvFow2V2HRfqytsweozlHS32sihg?= =?us-ascii?Q?wCXIS3PeJB/DV3EcKAdEn1/nqNiESm1xjCGMfpq1wTJFyt9Cr5ixxUyH7Fqi?= =?us-ascii?Q?+rOgwTsgCcJP7FlA9iFh0BX2qTJIUaz3HyFOmtZnt6lAjjLrgixVzgUTsjCW?= =?us-ascii?Q?vLwx8OKEm+43eIQRn+p3+cpLuO5tRfdaU4CVVQbZ7LWz4yE2gHIF+pICfHuN?= =?us-ascii?Q?tEvwkz35AQ2uEjSBFQPII6akGc3eM6mo9gOEqWuh7Fw5db8d7VwbG6mxW9f+?= =?us-ascii?Q?s04OE0nM5JIvkAe9J0qmfiPi3tZNaQ2KFECHxu5M1d0k91EPpwMFoUVv0Mzp?= =?us-ascii?Q?l3YV076EQjGSg+ppXq/GYLYzu5RpEd1W/OW95ZXM/bDw8GOQpeq9XFLTtcaw?= =?us-ascii?Q?lnLZQB9pVmo5yqsCKb2XOmPXeJf6d+GNRRPmfPFfrZtXi7ruRP2uvH65Qe/p?= =?us-ascii?Q?q0GFsDRxZnvLhqVIiTFF3hHdNi9tKufP+IPv23v7/YYhTTQxMCsl47LpnYNt?= =?us-ascii?Q?5u//rFhreT4pKJzY7SvrtmRMlkggKbLBttMfYzz8OHaWBafvnxk+sv9o90G6?= =?us-ascii?Q?zNte/NIi7UG8L6bgaucr3dgvYVm0kx1VbMAs7JfNAbudTSPgE2pjGRUq2Q0K?= =?us-ascii?Q?4MPGBJHQHgXm4E=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN4PR12MB0852;5:xixWN3TD2Qto0oONp6iStT0/29lYrniJizSRRJ7EoA62vkHxS5QNEjtCtzD5bBTVo3ntlucIsPNE3oeoXgqDKrREY0sdF7kY6WNyhX6tSrb7Tt23G1OZuMh/GDqb4WOZG74pkTD+KcNpXLA7qpAcPA==;24:S77OcIH6REIszkiNI1eH/hL7Xwp0uSVl6olSbiyli7A5514PWgLZSfCiVyXSFS/qsKOxfOKBP6Nf6xSE74XpYWRMuC9Rv3rypBswlZdnC4A=;20:pCXmispyVvjh8Fpz4oD5G2c3IReJzi9D3I3dlZKnu9OInBJbfkgH/PbpLqeT7lsMWimOTtIYEb2O7P2lGqjr/g== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2015 10:19:58.5820 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.221];Helo=[atltwp01.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN4PR12MB0852 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1306 Lines: 37 On Fri, Aug 28, 2015 at 04:04:18PM +0800, Ingo Molnar wrote: > > * Borislav Petkov wrote: > > > On Thu, Aug 27, 2015 at 04:07:40PM +0800, Huang Rui wrote: > > > Add an accessor function amd_get_cores_per_cu() which returns the > > > number of cores per compute unit. > > > > > > In a subsequent patch, we will use this function in fam15h_power > > > driver. > > > > > > Signed-off-by: Huang Rui > > > --- > > > arch/x86/include/asm/processor.h | 1 + > > > arch/x86/kernel/cpu/amd.c | 19 +++++++++++++++++-- > > > 2 files changed, 18 insertions(+), 2 deletions(-) > > > > Btw, this needs an ACK from a tip person if it goes through the hwmon > > tree. > > Looks good to me in theory. > > I suspect we might want to factor the 'compute unit' logic out a bit more if usage > becomes more widespread - but right now it's hwmon drivers only,right? > Actually, the cores with the same compute unit share some resources such as power domain, it might be useful in other parts not only for hwmon. :) Thanks, Rui -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/