Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752234AbbH1NU4 (ORCPT ); Fri, 28 Aug 2015 09:20:56 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:36739 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751963AbbH1NUz (ORCPT ); Fri, 28 Aug 2015 09:20:55 -0400 Date: Fri, 28 Aug 2015 14:20:52 +0100 From: Matt Fleming To: Jiri Olsa Cc: Arnaldo Carvalho de Melo , lkml , David Ahern , Ingo Molnar , Namhyung Kim , Peter Zijlstra , =?iso-8859-1?Q?Rapha=EBl?= Beamonte Subject: Re: [PATCH 09/11] perf tools: Propagate error info for the tracepoint parsing Message-ID: <20150828132052.GF2759@codeblueprint.co.uk> References: <1440596813-12844-1-git-send-email-jolsa@kernel.org> <1440596813-12844-10-git-send-email-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1440596813-12844-10-git-send-email-jolsa@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1201 Lines: 28 On Wed, 26 Aug, at 03:46:51PM, Jiri Olsa wrote: > Pass 'struct parse_events_error *error' to the parse-event.c > tracepoint adding path. It will be filled with error data > in following patches. > > Link: http://lkml.kernel.org/n/tip-las1hm5zf58b0twd27h9895b@git.kernel.org > Signed-off-by: Jiri Olsa > --- > tools/perf/util/parse-events.c | 27 ++++++++++++++++----------- > tools/perf/util/parse-events.h | 3 ++- > tools/perf/util/parse-events.y | 4 ++-- > 3 files changed, 20 insertions(+), 14 deletions(-) Is there a reason you decided to go ahead with passing 'data->error' directly to the parsing functions instead of adding some global state for recording errors, like a globally accessible 'parse_events_error'? Because I notice that if someone wanted to improve the breakpoint parsing code, they'd basically need to make the same changes you've made in this patch. -- Matt Fleming, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/