Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752615AbbH1Nvm (ORCPT ); Fri, 28 Aug 2015 09:51:42 -0400 Received: from lucky1.263xmail.com ([211.157.147.130]:41777 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752447AbbH1Nvj (ORCPT ); Fri, 28 Aug 2015 09:51:39 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: shawn.lin@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 220.200.5.94 X-LOGIN-NAME: shawn.lin@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [RESEND PATCH] mmc: core: fix race condition in mmc_wait_data_done To: Jialing Fu , Ulf Hansson References: <1440731589-22241-1-git-send-email-shawn.lin@rock-chips.com> <55DFD4B7.3070601@rock-chips.com> <55E02F7C.1020204@rock-chips.com> <1243788837884e859a8959cf8265125c@SC-EXCH04.marvell.com> Cc: shawn.lin@rock-chips.com, linux-mmc , "linux-kernel@vger.kernel.org" From: Shawn Lin Message-ID: <55E06760.8020308@rock-chips.com> Date: Fri, 28 Aug 2015 21:51:28 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1243788837884e859a8959cf8265125c@SC-EXCH04.marvell.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1345 Lines: 51 在 2015/8/28 18:22, Jialing Fu 写道: > > [...] > >>>> Hi, ulf >>>> >>>> We find this bug on Intel-C3230RK platform for very small probability. >>>> >>>> Whereas I can easily reproduce this case if I add a mdelay(1) or >>>> longer delay as Jialing did. >>>> >>>> This patch seems useful to me. Should we push it forward? :) >>> >>> >>> It seems like a very good idea! >>> >>> Should we add a fixes tag to it? >> >> >> That's cool, but how to add a fixes tag? >> >> [Fixes] mmc: core: fix race condition in mmc_wait_data_done ? :) >> > > A fixes tag points to an old commit which introduced the bug. If we can't find one, we can add a Cc tag to "stable". Just search the git log and you will find examples. > > Like add one line as below? > Fixes: 2220eedfd7ae ("mmc: fix async request mechanism for sequential read scenarios") > That's it, Jialing. From my git blame, seems this bug has been introduced for a long time, but I feel strange that no one had captured it before you did. Anyway, I will add a fixes tag and send v2 ASAP. :) > > Kind regards > Uffe > -- Best Regards Shawn Lin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/