Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752645AbbH1OXw (ORCPT ); Fri, 28 Aug 2015 10:23:52 -0400 Received: from mail.kernel.org ([198.145.29.136]:49103 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752446AbbH1OXv (ORCPT ); Fri, 28 Aug 2015 10:23:51 -0400 Date: Fri, 28 Aug 2015 11:23:31 -0300 From: "acme@kernel.org" To: "Liang, Kan" Cc: Jiri Olsa , "jolsa@kernel.org" , "ak@linux.intel.com" , "namhyung@kernel.org" , "eranian@google.com" , "Hunter, Adrian" , "dsahern@gmail.com" , "a.p.zijlstra@chello.nl" , "mingo@redhat.com" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH V2 1/3] perf,tools: get correct cpu id for print_aggr Message-ID: <20150828142331.GD31339@kernel.org> References: <1435820925-51091-1-git-send-email-kan.liang@intel.com> <20150702161302.GD19742@krava.brq.redhat.com> <37D7C6CF3E00A74B8858931C1DB2F077018F4065@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <37D7C6CF3E00A74B8858931C1DB2F077018F4065@SHSMSX103.ccr.corp.intel.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2276 Lines: 50 Em Fri, Aug 28, 2015 at 01:33:22PM +0000, Liang, Kan escreveu: > > On Thu, Jul 02, 2015 at 03:08:43AM -0400, kan.liang@intel.com wrote: > > > From: Kan Liang > > > print_aggr fails to print per-core/per-socket statistics after commit > > > 582ec0829b3d ("perf stat: Fix per-socket output bug for uncore > > > events") if events have differnt cpus. Because in print_aggr, > > > aggr_get_id needs index (not cpu id) to find core/pkg id. Also, evsel > > > cpu maps should be used to get aggregated id. > > > Signed-off-by: Kan Liang > > Acked-by: Jiri Olsa > Hi Arnaldo, > Could you please merge this patch? > This patch is to fix a bug of perf stat. It doesn't depend on > other patches of the patchset, and can be merged by itself. Right, in such cases, please, make it clear against which branch this should be applied, i.e. if this is a longstanding bug that needs to go to perf/urgent, i.e. to the current merge window, ASAP, or if this is for something that was introduced in the current development branch, perf/core. In this case it needs to go to perf/urgent, where it applies cleanly, perf/core has extra stuff there that fuzzes a bit. Also, since you know the cset where this bug was introduced, please consider adding a "Fixes:" tag, commom everywhere in the kernel: [acme@zoo linux]$ git log | grep '^[ \t]\+Fixes:' | wc -l 3805 And we use it in tools/, sometime I add it while editing changelogs, like in this patch: [acme@zoo linux]$ git log tools/ | grep '^[ \t]\+Fixes:' | head -5 Fixes: 582ec0829b3d ("perf stat: Fix per-socket output bug for uncore events") Fixes: b685ac22b436 ("perf symbols: Add front end cache for DSO symbol lookup") Fixes: 06b234ec26fd ("perf script: Don't assume evsel position of tracking events") Fixes: d4957633bf9d ("perf report: Add infrastructure for a cycles histogram") Fixes: 75186a9b09e4 ("perf probe: Fix to show lines of sys_ functions correctly") [acme@zoo linux]$ - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/