Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752740AbbH1OpY (ORCPT ); Fri, 28 Aug 2015 10:45:24 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:38529 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751989AbbH1OpW (ORCPT ); Fri, 28 Aug 2015 10:45:22 -0400 MIME-Version: 1.0 In-Reply-To: <37D7C6CF3E00A74B8858931C1DB2F077018F4AC2@SHSMSX103.ccr.corp.intel.com> References: <1435820925-51091-1-git-send-email-kan.liang@intel.com> <20150702161302.GD19742@krava.brq.redhat.com> <37D7C6CF3E00A74B8858931C1DB2F077018F4065@SHSMSX103.ccr.corp.intel.com> <20150828142331.GD31339@kernel.org> <37D7C6CF3E00A74B8858931C1DB2F077018F4AC2@SHSMSX103.ccr.corp.intel.com> Date: Fri, 28 Aug 2015 07:45:21 -0700 Message-ID: Subject: Re: [PATCH V2 1/3] perf,tools: get correct cpu id for print_aggr From: Stephane Eranian To: "Liang, Kan" Cc: "acme@kernel.org" , Jiri Olsa , "jolsa@kernel.org" , "ak@linux.intel.com" , "namhyung@kernel.org" , "Hunter, Adrian" , "dsahern@gmail.com" , "a.p.zijlstra@chello.nl" , "mingo@redhat.com" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2725 Lines: 66 On Fri, Aug 28, 2015 at 7:39 AM, Liang, Kan wrote: > > > > > Em Fri, Aug 28, 2015 at 01:33:22PM +0000, Liang, Kan escreveu: > > > > On Thu, Jul 02, 2015 at 03:08:43AM -0400, kan.liang@intel.com wrote: > > > > > From: Kan Liang print_aggr fails to print > > > > > per-core/per-socket statistics after commit 582ec0829b3d ("perf > > > > > stat: Fix per-socket output bug for uncore > > > > > events") if events have differnt cpus. Because in print_aggr, > > > > > aggr_get_id needs index (not cpu id) to find core/pkg id. Also, > > > > > evsel cpu maps should be used to get aggregated id. > > > > > Signed-off-by: Kan Liang > > > > > > Acked-by: Jiri Olsa > > > > > Hi Arnaldo, > > > > > Could you please merge this patch? > > > This patch is to fix a bug of perf stat. It doesn't depend on other > > > patches of the patchset, and can be merged by itself. > > > > Right, in such cases, please, make it clear against which branch this should > > be applied, i.e. if this is a longstanding bug that needs to go to perf/urgent, > > i.e. to the current merge window, ASAP, or if this is for something that was > > introduced in the current development branch, perf/core. > > > > In this case it needs to go to perf/urgent, where it applies cleanly, > > perf/core has extra stuff there that fuzzes a bit. > > > > Also, since you know the cset where this bug was introduced, please > > consider adding a "Fixes:" tag, commom everywhere in the kernel: > > OK. I think this patch needs to go to perf/urgent. > Should I re-send this patch with "Fixes:" tag and comments? > Acked-by: Stephane Eranian > > Thanks, > Kan > > > > [acme@zoo linux]$ git log | grep '^[ \t]\+Fixes:' | wc -l > > 3805 > > > > And we use it in tools/, sometime I add it while editing changelogs, like in > > this patch: > > > > [acme@zoo linux]$ git log tools/ | grep '^[ \t]\+Fixes:' | head -5 > > Fixes: 582ec0829b3d ("perf stat: Fix per-socket output bug for uncore > > events") > > Fixes: b685ac22b436 ("perf symbols: Add front end cache for DSO symbol > > lookup") > > Fixes: 06b234ec26fd ("perf script: Don't assume evsel position of tracking > > events") > > Fixes: d4957633bf9d ("perf report: Add infrastructure for a cycles > > histogram") > > Fixes: 75186a9b09e4 ("perf probe: Fix to show lines of sys_ functions > > correctly") > > [acme@zoo linux]$ > > > > - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/