Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752733AbbH1PGz (ORCPT ); Fri, 28 Aug 2015 11:06:55 -0400 Received: from smtp.citrix.com ([66.165.176.89]:16204 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752544AbbH1PGy (ORCPT ); Fri, 28 Aug 2015 11:06:54 -0400 X-IronPort-AV: E=Sophos;i="5.17,425,1437436800"; d="scan'208";a="295563480" Message-ID: <55E07832.1010802@citrix.com> Date: Fri, 28 Aug 2015 16:03:14 +0100 From: Julien Grall User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: David Vrabel , CC: Jiri Slaby , , , Greg Kroah-Hartman , , Boris Ostrovsky , , Subject: Re: [Xen-devel] [PATCH v3 11/20] tty/hvc: xen: Use xen page definition References: <1438966019-19322-1-git-send-email-julien.grall@citrix.com> <1438966019-19322-12-git-send-email-julien.grall@citrix.com> <55D5A42E.7070800@citrix.com> In-Reply-To: <55D5A42E.7070800@citrix.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 892 Lines: 29 Hi David, On 20/08/15 10:55, David Vrabel wrote: > On 07/08/15 17:46, Julien Grall wrote: >> The console ring is always based on the page granularity of Xen. > [...] >> --- a/drivers/tty/hvc/hvc_xen.c >> +++ b/drivers/tty/hvc/hvc_xen.c >> @@ -230,7 +230,7 @@ static int xen_hvm_console_init(void) >> if (r < 0 || v == 0) >> goto err; >> gfn = v; >> - info->intf = xen_remap(gfn << PAGE_SHIFT, PAGE_SIZE); >> + info->intf = xen_remap(gfn << XEN_PAGE_SHIFT, PAGE_SIZE); > > You need XEN_PAGE_SIZE here I think... Right, I did the mistake while rebase on my s/mfn/gfn/ series. I will fix it in the next version. Regards, -- Julien Grall -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/