Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752609AbbH1QWA (ORCPT ); Fri, 28 Aug 2015 12:22:00 -0400 Received: from mail.kernel.org ([198.145.29.136]:56308 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751924AbbH1QV7 (ORCPT ); Fri, 28 Aug 2015 12:21:59 -0400 Date: Fri, 28 Aug 2015 13:21:39 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: lkml , David Ahern , Ingo Molnar , Namhyung Kim , Peter Zijlstra , Matt Fleming , =?iso-8859-1?Q?Rapha=EBl?= Beamonte Subject: Re: [PATCH 01/11] tools: Add err.h with ERR_PTR PTR_ERR interface Message-ID: <20150828162139.GE11407@kernel.org> References: <1440596813-12844-1-git-send-email-jolsa@kernel.org> <1440596813-12844-2-git-send-email-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1440596813-12844-2-git-send-email-jolsa@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2169 Lines: 74 Em Wed, Aug 26, 2015 at 03:46:43PM +0200, Jiri Olsa escreveu: > Adding part of the kernel's interface: > inline void * __must_check ERR_PTR(long error); > inline long __must_check PTR_ERR(__force const void *ptr); > inline bool __must_check IS_ERR(__force const void *ptr); > > it will be used to propagate error through pointers > in following patches. > > Link: http://lkml.kernel.org/n/tip-ufgnyf683uab69anmmrabgdf@git.kernel.org > Signed-off-by: Jiri Olsa > --- > tools/include/linux/err.h | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > create mode 100644 tools/include/linux/err.h > > diff --git a/tools/include/linux/err.h b/tools/include/linux/err.h > new file mode 100644 > index 000000000000..2df92df55cfe > --- /dev/null > +++ b/tools/include/linux/err.h > @@ -0,0 +1,28 @@ > +#ifndef __TOOLS_LINUX_ERR_H > +#define __TOOLS_LINUX_ERR_H > + > +#include > +#include > + > +#include > + You deleted the comment in the kernel sources at this point: /* * Kernel pointers have redundant information, so we can use a * scheme where we can return either an error code or a normal * pointer with the same return value. * * This should be a per-architecture thing, to allow different * error and pointer decisions. */ > +#define MAX_ERRNO 4095 Now we're dealing with user pointers, are we completely sure we can use this trick here? - Arnaldo > +#define IS_ERR_VALUE(x) unlikely((x) >= (unsigned long)-MAX_ERRNO) > + > +static inline void * __must_check ERR_PTR(long error) > +{ > + return (void *) error; > +} > + > +static inline long __must_check PTR_ERR(__force const void *ptr) > +{ > + return (long) ptr; > +} > + > +static inline bool __must_check IS_ERR(__force const void *ptr) > +{ > + return IS_ERR_VALUE((unsigned long)ptr); > +} > + > +#endif /* _LINUX_ERR_H */ > -- > 2.4.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/