Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752552AbbH1Q1q (ORCPT ); Fri, 28 Aug 2015 12:27:46 -0400 Received: from mail.kernel.org ([198.145.29.136]:56648 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751739AbbH1Q1p (ORCPT ); Fri, 28 Aug 2015 12:27:45 -0400 Date: Fri, 28 Aug 2015 13:27:22 -0300 From: Arnaldo Carvalho de Melo To: Matt Fleming Cc: Jiri Olsa , lkml , David Ahern , Ingo Molnar , Namhyung Kim , Peter Zijlstra , =?iso-8859-1?Q?Rapha=EBl?= Beamonte Subject: Re: [PATCH 02/11] perf tools: Add tracing_path and remove unneeded functions Message-ID: <20150828162722.GF11407@kernel.org> References: <1440596813-12844-1-git-send-email-jolsa@kernel.org> <1440596813-12844-3-git-send-email-jolsa@kernel.org> <20150827224719.GE3596@codeblueprint.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150827224719.GE3596@codeblueprint.co.uk> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1113 Lines: 24 Em Thu, Aug 27, 2015 at 11:47:19PM +0100, Matt Fleming escreveu: > On Wed, 26 Aug, at 03:46:44PM, Jiri Olsa wrote: > > There's no need for find_tracing_dir, because perf already > > searches for debugfs/tracefs mount on start and populate > > tracing_events_path. > > I'm getting a bit lost searching through the git history of these > functions. Why is it safe to delete these functions? Where did the old > user that required find_tracing_dir() to mount debugfs disappear to? > > The code to do the mount of debugfs/tracefs when perf starts appears > to have been around for years. Is the mounting operation of > find_tracing_dir() just dead code? It looks like, these things should come after we realize that tracepoints were requested in record, so we already looked where things are mounted, etc, without digging deeper I think Jiri's patch is ok. - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/