Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752734AbbH1RTA (ORCPT ); Fri, 28 Aug 2015 13:19:00 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:33567 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752051AbbH1RS7 (ORCPT ); Fri, 28 Aug 2015 13:18:59 -0400 Date: Fri, 28 Aug 2015 10:18:56 -0700 From: Brian Norris To: Roger Quadros Cc: dwmw2@infradead.org, akinobu.mita@gmail.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mtd: mtd_oobtest: Fix the address offset with vary_offset case Message-ID: <20150828171856.GA81844@google.com> References: <1436356219-5085-1-git-send-email-rogerq@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436356219-5085-1-git-send-email-rogerq@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 821 Lines: 18 On Wed, Jul 08, 2015 at 02:50:19PM +0300, Roger Quadros wrote: > When vary_offset is set (e.g. test case 3), the offset is not always > zero so memcmpshow() will show the wrong offset in the print message. > To fix this we introduce a new function memcmpshowoffset() which takes > offset as a parameter and displays the right offset and use it in > the case where offset is non zero. > > The old memcmpshow() functionality is preserved by converting it into > a macro with offset preset to 0. > > Signed-off-by: Roger Quadros Applied to l2-mtd.git. Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/