Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753249AbbH1WfX (ORCPT ); Fri, 28 Aug 2015 18:35:23 -0400 Received: from seldrel01.sonyericsson.com ([37.139.156.2]:7466 "EHLO seldrel01.sonyericsson.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752860AbbH1WfV (ORCPT ); Fri, 28 Aug 2015 18:35:21 -0400 Date: Fri, 28 Aug 2015 13:01:06 -0700 From: Bjorn Andersson To: Stephen Boyd CC: Greg Kroah-Hartman , , , , Andy Gross Subject: Re: [PATCH] spmi: pmic-arb: Don't byte swap when reading/writing FIFO Message-ID: <20150828200106.GU13472@usrtlx11787.corpusers.net> References: <1440789702-1648-1-git-send-email-sboyd@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1440789702-1648-1-git-send-email-sboyd@codeaurora.org> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 863 Lines: 22 On Fri 28 Aug 12:21 PDT 2015, Stephen Boyd wrote: > We don't want to swap bytes that we're reading and writing to the > FIFOs when we're running on a big-endian CPU. Doing so causes > problems like where the qcom-spmi-iadc driver can't detect the > type of device because the bytes are all mixed up. Use the raw IO > accessors for these API instead, and collapse pmic_arb_base_read() > into the byte reading API so that we aren't tempted to read non-FIFO > data like commands with that function. > > Cc: Andy Gross Acked-by: Bjorn Andersson Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/