Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753219AbbH1VJu (ORCPT ); Fri, 28 Aug 2015 17:09:50 -0400 Received: from smtprelay0008.hostedemail.com ([216.40.44.8]:54670 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752481AbbH1VJs (ORCPT ); Fri, 28 Aug 2015 17:09:48 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:967:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2525:2560:2563:2682:2685:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3871:3872:3873:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:5007:6119:6120:6261:6742:7808:7901:7903:8985:9025:10004:10400:10848:11232:11658:11914:12043:12296:12438:12517:12519:12740:13069:13255:13311:13357:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: rose25_1ad013bfe262a X-Filterd-Recvd-Size: 2594 Message-ID: <1440796183.11525.153.camel@perches.com> Subject: Re: [PATCH RFC V2 2/2] net: Optimize snmp stat aggregation by walking all the percpu data at once From: Joe Perches To: Eric Dumazet Cc: David Miller , raghavendra.kt@linux.vnet.ibm.com, edumazet@google.com, kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, jiri@resnulli.us, hannes@stressinduktion.org, tom@herbertland.com, azhou@nicira.com, ebiederm@xmission.com, ipm@chirality.org.uk, nicolas.dichtel@6wind.com, serge.hallyn@canonical.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, anton@au1.ibm.com, nacc@linux.vnet.ibm.com, srikar@linux.vnet.ibm.com Date: Fri, 28 Aug 2015 14:09:43 -0700 In-Reply-To: <1440795336.8932.46.camel@edumazet-glaptop2.roam.corp.google.com> References: <1440610653-14210-3-git-send-email-raghavendra.kt@linux.vnet.ibm.com> <20150827.113823.214019265460582055.davem@davemloft.net> <55E00238.10909@linux.vnet.ibm.com> <20150828.112413.424099339331017970.davem@davemloft.net> <1440789654.11525.137.camel@perches.com> <1440794020.8932.45.camel@edumazet-glaptop2.roam.corp.google.com> <1440795211.11525.146.camel@perches.com> <1440795336.8932.46.camel@edumazet-glaptop2.roam.corp.google.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1106 Lines: 31 On Fri, 2015-08-28 at 13:55 -0700, Eric Dumazet wrote: > On Fri, 2015-08-28 at 13:53 -0700, Joe Perches wrote: > > On Fri, 2015-08-28 at 13:33 -0700, Eric Dumazet wrote: > > > We do not bother for small struct. > > > > > > Here, the array is big enough that David prefers having an explicit > > > memset() so that it clearly shows that author of this code was aware of > > > this. > > > > It's 288 bytes on stack, maybe a kzalloc would be clearer too. > > Could you read patch history and check why this has been rejected ? I don't see a rejection, just that the initial submission didn't check the allocation or add an allocation buffer via kcalloc/kzalloc to the inet6_fill_ifla6_attrs caller and change the snmp6_fill_stats arguments. It could also eliminate the put_unaligned calls. https://lkml.org/lkml/2015/8/25/114 Was there some other thread? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/