Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752926AbbH1VrU (ORCPT ); Fri, 28 Aug 2015 17:47:20 -0400 Received: from mail-vk0-f45.google.com ([209.85.213.45]:36625 "EHLO mail-vk0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752770AbbH1VrT (ORCPT ); Fri, 28 Aug 2015 17:47:19 -0400 MIME-Version: 1.0 In-Reply-To: <1440798084.14237.106.camel@hp.com> References: <20150826010220.8851.18077.stgit@dwillia2-desk3.amr.corp.intel.com> <20150826012751.8851.78564.stgit@dwillia2-desk3.amr.corp.intel.com> <20150826124124.GA7613@lst.de> <1440624859.31365.17.camel@intel.com> <1440798084.14237.106.camel@hp.com> Date: Fri, 28 Aug 2015 14:47:18 -0700 Message-ID: Subject: Re: [PATCH v2 5/9] x86, pmem: push fallback handling to arch code From: Dan Williams To: Toshi Kani Cc: "hch@lst.de" , "linux-kernel@vger.kernel.org" , "mingo@kernel.org" , "linux-mm@kvack.org" , "tglx@linutronix.de" , "hpa@zytor.com" , "linux-nvdimm@lists.01.org" , "mingo@redhat.com" , "ross.zwisler@linux.intel.com" , "boaz@plexistor.com" , "david@fromorbit.com" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 752 Lines: 20 On Fri, Aug 28, 2015 at 2:41 PM, Toshi Kani wrote: > On Wed, 2015-08-26 at 21:34 +0000, Williams, Dan J wrote: [..] >> -#define ARCH_MEMREMAP_PMEM MEMREMAP_WB > > Should it be better to do: > > #else /* !CONFIG_ARCH_HAS_PMEM_API */ > #define ARCH_MEMREMAP_PMEM MEMREMAP_WT > > so that you can remove all '#ifdef ARCH_MEMREMAP_PMEM' stuff? Yeah, that seems like a nice incremental cleanup for memremap_pmem() to just unconditionally use ARCH_MEMREMAP_PMEM, feel free to send it along. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/