Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753181AbbH1Vuh (ORCPT ); Fri, 28 Aug 2015 17:50:37 -0400 Received: from g9t5008.houston.hp.com ([15.240.92.66]:39694 "EHLO g9t5008.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752750AbbH1Vug (ORCPT ); Fri, 28 Aug 2015 17:50:36 -0400 Message-ID: <1440798506.14237.107.camel@hp.com> Subject: Re: [PATCH v2 5/9] x86, pmem: push fallback handling to arch code From: Toshi Kani To: Dan Williams Cc: "hch@lst.de" , "linux-kernel@vger.kernel.org" , "mingo@kernel.org" , "linux-mm@kvack.org" , "tglx@linutronix.de" , "hpa@zytor.com" , "linux-nvdimm@lists.01.org" , "mingo@redhat.com" , "ross.zwisler@linux.intel.com" , "boaz@plexistor.com" , "david@fromorbit.com" Date: Fri, 28 Aug 2015 15:48:26 -0600 In-Reply-To: References: <20150826010220.8851.18077.stgit@dwillia2-desk3.amr.corp.intel.com> <20150826012751.8851.78564.stgit@dwillia2-desk3.amr.corp.intel.com> <20150826124124.GA7613@lst.de> <1440624859.31365.17.camel@intel.com> <1440798084.14237.106.camel@hp.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.4 (3.16.4-2.fc22) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 871 Lines: 26 On Fri, 2015-08-28 at 14:47 -0700, Dan Williams wrote: > On Fri, Aug 28, 2015 at 2:41 PM, Toshi Kani wrote: > > On Wed, 2015-08-26 at 21:34 +0000, Williams, Dan J wrote: > [..] > > > -#define ARCH_MEMREMAP_PMEM MEMREMAP_WB > > > > Should it be better to do: > > > > #else /* !CONFIG_ARCH_HAS_PMEM_API */ > > #define ARCH_MEMREMAP_PMEM MEMREMAP_WT > > > > so that you can remove all '#ifdef ARCH_MEMREMAP_PMEM' stuff? > > Yeah, that seems like a nice incremental cleanup for memremap_pmem() > to just unconditionally use ARCH_MEMREMAP_PMEM, feel free to send it > along. OK. Will do. Thanks, -Toshi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/