Subject: Re: [PATCH v2 net-next 1/2] lib: introduce strncpy_from_unsafe()
To: Steven Rostedt <rostedt@goodmis.org>
References: <1440791509-5450-1-git-send-email-ast@plumgrid.com>
 <1440791509-5450-2-git-send-email-ast@plumgrid.com>
 <20150828174813.23e6e78b@gandalf.local.home>
Cc: "David S. Miller" <davem@davemloft.net>, Ingo Molnar <mingo@kernel.org>,
        Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
        Wang Nan <wangnan0@huawei.com>, He Kuang <hekuang@huawei.com>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Brendan Gregg <brendan.d.gregg@gmail.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
From: Alexei Starovoitov <ast@plumgrid.com>
Message-ID: <55E0DBE3.8010504@plumgrid.com>
Date: Fri, 28 Aug 2015 15:08:35 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0)
 Gecko/20100101 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <20150828174813.23e6e78b@gandalf.local.home>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 902
Lines: 21

On 8/28/15 2:48 PM, Steven Rostedt wrote:
>>   * On success, returns the length of the string (not including the trailing
>> >+ * NUL).
> I think it includes the NUL.

oops. yes. that was a copy paste from strncpy_from_user comment.
trace_kprobe usage wants NUL to be counted, so I intended to have it
counted, but that brings the question what should be the semantics.
Should it be similar to strncpy_from_user (not counting NUL) or
similar to strlen_user (counts NUL) ?
imo counting NUL makes a little bit more sense, since when a user says
strncpy_from_unsafe(..., ..., 32)
and it returns 32 as the whole buffer was filled, it looks cleaner.
Thoughts?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/