Return-Path: <linux-kernel-owner+willy=40w.ods.org@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id <S267949AbTBVW5I>; Sat, 22 Feb 2003 17:57:08 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org
	id <S267951AbTBVW5I>; Sat, 22 Feb 2003 17:57:08 -0500
Received: from [212.156.4.132] ([212.156.4.132]:54777 "EHLO fep02.ttnet.net.tr")
	by vger.kernel.org with ESMTP id <S267949AbTBVW5H>;
	Sat, 22 Feb 2003 17:57:07 -0500
Date: Sun, 23 Feb 2003 01:07:22 +0200
From: Faik Uygur <faikuygur@ttnet.net.tr>
To: andre@linux-ide.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] 2.5.62: /proc/ide/pdcnew returns incomplete data [8/17]
Message-ID: <20030222230722.GG2996@ttnet.net.tr>
Mail-Followup-To: andre@linux-ide.org, linux-kernel@vger.kernel.org
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-9
Content-Disposition: inline
User-Agent: Mutt/1.4i
X-PGP-Fingerprint: 15 C0 AA 31 59 F9 DE 4F 7D A6 C7 D8 A0 D5 67 73
X-PGP-Key-ID: 0x5C447959
X-PGP-Key-Size: 2048 bits
X-Editor: GNU Emacs 21.2.1
X-Operating-System: Debian GNU/Linux
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1131
Lines: 30

This patch fixes the incomplete data return problem of /proc/ide/pdcnew.
When the number of consecutive read bytes are smaller than the total
data in pdcnew_get_info(), the second read() returns 0.

--- linux-2.5.62-vanilla/drivers/ide/pci/pdc202xx_new.c	Sat Feb 22 23:00:52 2003
+++ linux-2.5.62/drivers/ide/pci/pdc202xx_new.c	Sat Feb 22 23:33:19 2003
@@ -77,13 +77,17 @@
 static int pdcnew_get_info (char *buffer, char **addr, off_t offset, int count)
 {
 	char *p = buffer;
-	int i;
+	int i, len;
 
 	for (i = 0; i < n_pdc202_devs; i++) {
 		struct pci_dev *dev	= pdc202_devs[i];
 		p = pdcnew_info(buffer, dev);
 	}
-	return p-buffer;	/* => must be less than 4k! */
+	/* p - buffer must be less than 4k! */
+	len = (p - buffer) - offset;
+	*addr = buffer + offset;
+	
+	return len > count ? count : len;
 }
 #endif  /* defined(DISPLAY_PDC202XX_TIMINGS) && defined(CONFIG_PROC_FS) */
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/