Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752934AbbH1Xk7 (ORCPT ); Fri, 28 Aug 2015 19:40:59 -0400 Received: from lucky1.263xmail.com ([211.157.147.131]:51429 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752645AbbH1Xk4 (ORCPT ); Fri, 28 Aug 2015 19:40:56 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: shawn.lin@rock-chips.com X-FST-TO: boojin.kim@samsung.com X-SENDER-IP: 220.200.5.118 X-LOGIN-NAME: shawn.lin@rock-chips.com X-UNIQUE-TAG: <9cfcad1b74f161b846eb4f3d3cc39eec> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH 1/5] DMA: pl330: support burst mode for dev-to-mem and mem-to-dev transmit To: Sonny Rao References: <1440665280-31557-1-git-send-email-shawn.lin@rock-chips.com> <1440665313-31603-1-git-send-email-shawn.lin@rock-chips.com> <55DF1072.1070905@rock-chips.com> Cc: shawn.lin@rock-chips.com, Krzysztof Kozlowski , Vinod Koul , Heiko Stuebner , Doug Anderson , Olof Johansson , Addy Ke , dmaengine@vger.kernel.org, "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Rockchip SoC..." , Boojin Kim From: Shawn Lin Message-ID: <55E0F179.2020601@rock-chips.com> Date: Sat, 29 Aug 2015 07:40:41 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5596 Lines: 162 在 2015/8/29 2:19, Sonny Rao 写道: > On Thu, Aug 27, 2015 at 6:28 AM, Shawn Lin wrote: >> 在 2015/8/27 20:57, Krzysztof Kozlowski 写道: >>> >>> 2015-08-27 17:48 GMT+09:00 Shawn Lin : >>>> >>>> >>>> This patch adds to support burst mode for dev-to-mem and >>>> mem-to-dev transmit. >>>> >>>> Signed-off-by: Boojin Kim >>>> Signed-off-by: Addy Ke >>>> Signed-off-by: Shawn Lin >>>> cc: Heiko Stuebner >>>> cc: Doug Anderson >>>> cc: Olof Johansson >>>> Reviewed-and-tested-by: Sonny Rao >>> >>> >>> For the entire patchset: I would prefer to see someone's >>> reviewed/tested tag in his response. Sending a version 1 of patchset >>> (regardless of Boojin Kim's work two years ago) with such tag could >>> mean anything. I cannot verify it easily (unless digging somewhere... >>> or asking people). You could add for example: Reviewed-by Santa Claus. >>> Should I sent a letter to him asking for confirmation? :) >>> >> >> :) yes, you are right. I should comply with the rule, even if the patchest >> had been reviewed or tested by someone on another tree. > > Hi, yeah I reviewed on a different tree, so you shouldn't put that tag > here, thanks for removing it. > I can re-review if you'd like. > Hi, sunny, Thanks for reply. It's very great if you can help me re-review the patchset here. :) >> >> >>> More seriously - reviewed-by is a statement (please look at >>> Documentation/SubmittingPatches) and you cannot force someone to make >>> that statement. He must make such statement on his own. >>> >>> That's all from my side since I don't feel skilled enough to review the >>> code. >>> >>> Best regards, >>> Krzysztof >>> >>>> >>>> --- >>>> >>>> drivers/dma/pl330.c | 18 ++++++++++++------ >>>> 1 file changed, 12 insertions(+), 6 deletions(-) >>>> >>>> diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c >>>> index ecab4ea0..0d544d2 100644 >>>> --- a/drivers/dma/pl330.c >>>> +++ b/drivers/dma/pl330.c >>>> @@ -1141,10 +1141,13 @@ static inline int _ldst_devtomem(unsigned >>>> dry_run, u8 buf[], >>>> const struct _xfer_spec *pxs, int cyc) >>>> { >>>> int off = 0; >>>> + enum pl330_cond cond; >>>> + >>>> + cond = (pxs->desc->rqcfg.brst_len == 1) ? SINGLE : BURST; >>>> >>>> while (cyc--) { >>>> - off += _emit_WFP(dry_run, &buf[off], SINGLE, >>>> pxs->desc->peri); >>>> - off += _emit_LDP(dry_run, &buf[off], SINGLE, >>>> pxs->desc->peri); >>>> + off += _emit_WFP(dry_run, &buf[off], cond, >>>> pxs->desc->peri); >>>> + off += _emit_LDP(dry_run, &buf[off], cond, >>>> pxs->desc->peri); >>>> off += _emit_ST(dry_run, &buf[off], ALWAYS); >>>> off += _emit_FLUSHP(dry_run, &buf[off], >>>> pxs->desc->peri); >>>> } >>>> @@ -1156,11 +1159,14 @@ static inline int _ldst_memtodev(unsigned >>>> dry_run, u8 buf[], >>>> const struct _xfer_spec *pxs, int cyc) >>>> { >>>> int off = 0; >>>> + enum pl330_cond cond; >>>> + >>>> + cond = (pxs->desc->rqcfg.brst_len == 1) ? SINGLE : BURST; >>>> >>>> while (cyc--) { >>>> - off += _emit_WFP(dry_run, &buf[off], SINGLE, >>>> pxs->desc->peri); >>>> + off += _emit_WFP(dry_run, &buf[off], cond, >>>> pxs->desc->peri); >>>> off += _emit_LD(dry_run, &buf[off], ALWAYS); >>>> - off += _emit_STP(dry_run, &buf[off], SINGLE, >>>> pxs->desc->peri); >>>> + off += _emit_STP(dry_run, &buf[off], cond, >>>> pxs->desc->peri); >>>> off += _emit_FLUSHP(dry_run, &buf[off], >>>> pxs->desc->peri); >>>> } >>>> >>>> @@ -2557,7 +2563,7 @@ static struct dma_async_tx_descriptor >>>> *pl330_prep_dma_cyclic( >>>> >>>> desc->rqtype = direction; >>>> desc->rqcfg.brst_size = pch->burst_sz; >>>> - desc->rqcfg.brst_len = 1; >>>> + desc->rqcfg.brst_len = pch->burst_len; >>>> desc->bytes_requested = period_len; >>>> fill_px(&desc->px, dst, src, period_len); >>>> >>>> @@ -2702,7 +2708,7 @@ pl330_prep_slave_sg(struct dma_chan *chan, struct >>>> scatterlist *sgl, >>>> } >>>> >>>> desc->rqcfg.brst_size = pch->burst_sz; >>>> - desc->rqcfg.brst_len = 1; >>>> + desc->rqcfg.brst_len = pch->burst_len; >>>> desc->rqtype = direction; >>>> desc->bytes_requested = sg_dma_len(sg); >>>> } >>>> -- >>>> 2.3.7 >>>> >>>> >>>> -- >>>> To unsubscribe from this list: send the line "unsubscribe dmaengine" in >>>> the body of a message to majordomo@vger.kernel.org >>>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>> >>> >>> >>> >> >> >> -- >> Best Regards >> Shawn Lin >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ > > > -- Best Regards Shawn Lin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/