Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753017AbbH1X5n (ORCPT ); Fri, 28 Aug 2015 19:57:43 -0400 Received: from mail-pa0-f54.google.com ([209.85.220.54]:33090 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752898AbbH1X5l (ORCPT ); Fri, 28 Aug 2015 19:57:41 -0400 Date: Sat, 29 Aug 2015 08:57:28 +0900 From: Simon Horman To: Joe Stringer Cc: netdev@vger.kernel.org, pshelar@nicira.com, linux-kernel@vger.kernel.org, pablo@netfilter.org, fwestpha@redhat.com, hannes@redhat.com, tgraf@suug.ch, jpettit@nicira.com, jesse@nicira.com, netfilter-devel@vger.kernel.org Subject: Re: [PATCHv6 net-next 00/10] OVS conntrack support Message-ID: <20150828235725.GA22045@vergenet.net> References: <1440613913-10141-1-git-send-email-joestringer@nicira.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1440613913-10141-1-git-send-email-joestringer@nicira.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2065 Lines: 44 On Wed, Aug 26, 2015 at 11:31:43AM -0700, Joe Stringer wrote: > The goal of this series is to allow OVS to send packets through the Linux > kernel connection tracker, and subsequently match on fields populated by > conntrack. This functionality is enabled through a new > CONFIG_OPENVSWITCH_CONNTRACK option. > > This version addresses the feedback from v5, primarily checking the behaviour > is correct with different configurations such as disabling > CONFIG_OPENVSWITCH_CONNTRACK or disabling individual conntrack features like > connlabels. > > The branch below has been updated with the corresponding userspace pieces: > https://github.com/joestringer/ovs dev/ct_20150818 Hi Joe, Nice work getting this patchset in order. I am seeing the following when compiling without NF_CONNTRACK_MARK set. CC [M] net/openvswitch//conntrack.o net/openvswitch//conntrack.c: In function ‘__ovs_ct_update_key’: net/openvswitch//conntrack.c:127:24: error: ‘const struct nf_conn’ has no member named ‘mark’ key->ct.mark = ct ? ct->mark : 0; ^ net/openvswitch//conntrack.c: In function ‘ovs_ct_set_mark’: net/openvswitch//conntrack.c:195:26: error: ‘struct nf_conn’ has no member named ‘mark’ new_mark = ct_mark | (ct->mark & ~(mask)); ^ net/openvswitch//conntrack.c:196:8: error: ‘struct nf_conn’ has no member named ‘mark’ if (ct->mark != new_mark) { ^ net/openvswitch//conntrack.c:197:5: error: ‘struct nf_conn’ has no member named ‘mark’ ct->mark = new_mark; ^ scripts/Makefile.build:258: recipe for target 'net/openvswitch//conntrack.o' failed make[1]: *** [net/openvswitch//conntrack.o] Error 1 Makefile:1386: recipe for target '_module_net/openvswitch/' failed make: *** [_module_net/openvswitch/] Error 2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/