MIME-Version: 1.0
In-Reply-To: <20150827165909.GA5506@goodgumbo.baconseed.org>
References: <20150827165909.GA5506@goodgumbo.baconseed.org>
Date: Fri, 28 Aug 2015 17:00:42 -0700
Message-ID: <CAKdAkRQhyZBHJKTBZD3_YxT_BOFrUZdyZvKEC+N=yCwUjZs0hw@mail.gmail.com>
Subject: Re: [PATCH 2/6] input: pwm-beeper: Fix module autoload for OF
 platform driver
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Luis de Bethencourt <luis@debethencourt.com>
Cc: lkml <linux-kernel@vger.kernel.org>, Jingoo Han <jg1.han@samsung.com>,
        Wolfram Sang <wsa@the-dreams.de>, Olivier Sobrie <olivier@sobrie.be>,
        "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
        Javier Martinez Canillas <javier@osg.samsung.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1259
Lines: 42

Hi Luis,

On Thu, Aug 27, 2015 at 9:59 AM, Luis de Bethencourt
<luis@debethencourt.com> wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
>
> Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>
> ---
>  drivers/input/misc/pwm-beeper.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/input/misc/pwm-beeper.c b/drivers/input/misc/pwm-beeper.c
> index e82edf8..a02b9a4 100644
> --- a/drivers/input/misc/pwm-beeper.c
> +++ b/drivers/input/misc/pwm-beeper.c
> @@ -175,6 +175,8 @@ static const struct of_device_id pwm_beeper_match[] = {
>  };
>  #endif
>
> +MODULE_DEVICE_TABLE(of, pwm_beeper_match);
> +

I'm fairly certain this (ano others) blow up in case of !CONFIG_OF.
Please bring MODULE_DEVICE_TABLE into #ifdef block above.

>  static struct platform_driver pwm_beeper_driver = {
>         .probe  = pwm_beeper_probe,
>         .remove = pwm_beeper_remove,
> --
> 2.4.6
>

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/