Subject: Re: [PATCH 32/32] bpf: Introduce function for outputing data to perf
 event
To: "Wangnan (F)" <wangnan0@huawei.com>, acme@redhat.com
References: <1440745570-150857-1-git-send-email-wangnan0@huawei.com>
 <1440745570-150857-33-git-send-email-wangnan0@huawei.com>
 <55E10091.6020107@plumgrid.com> <55E108BC.4050107@huawei.com>
 <55E10C2D.5090300@plumgrid.com> <55E115BD.6090909@huawei.com>
 <55E1174A.2000102@plumgrid.com> <55E11AB1.5020203@huawei.com>
Cc: brendan.d.gregg@gmail.com, daniel@iogearbox.net, dsahern@gmail.com,
        hekuang@huawei.com, jolsa@kernel.org, xiakaixu@huawei.com,
        masami.hiramatsu.pt@hitachi.com, namhyung@kernel.org,
        a.p.zijlstra@chello.nl, lizefan@huawei.com, pi3orama@163.com,
        linux-kernel@vger.kernel.org,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Ingo Molnar <mingo@redhat.com>, Steven Rostedt <rostedt@goodmis.org>
From: Alexei Starovoitov <ast@plumgrid.com>
Message-ID: <55E11DC7.80709@plumgrid.com>
Date: Fri, 28 Aug 2015 19:49:43 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0)
 Gecko/20100101 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <55E11AB1.5020203@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 662
Lines: 15

On 8/28/15 7:36 PM, Wangnan (F) wrote:
> For current patch 32/32, I think it is useful enough for some simple cases,
> and we have already start using it internally. What about keep it as
> what it
> is now and create a independent method for your usecase?

well, though the patch is small and contained, I think we can do better
and define more generic helper. I believe Namhyung back in July had
the same concern.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/