Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751946AbbH2Dbi (ORCPT ); Fri, 28 Aug 2015 23:31:38 -0400 Received: from mail-vk0-f53.google.com ([209.85.213.53]:36066 "EHLO mail-vk0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751568AbbH2Dbh (ORCPT ); Fri, 28 Aug 2015 23:31:37 -0400 MIME-Version: 1.0 In-Reply-To: <1440811124-1634-1-git-send-email-toshi.kani@hp.com> References: <1440811124-1634-1-git-send-email-toshi.kani@hp.com> Date: Fri, 28 Aug 2015 20:31:35 -0700 Message-ID: Subject: Re: [PATCH] nfit: Fix undefined mmio_flush_range on x86_32 From: Dan Williams To: Toshi Kani Cc: Ross Zwisler , "linux-nvdimm@lists.01.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1100 Lines: 26 On Fri, Aug 28, 2015 at 6:18 PM, Toshi Kani wrote: > The following compile error was observed on x86_32 since nfit.c > relies on to include , which only > works when CONFIG_ARCH_HAS_PMEM_API is set on x86_64. > > drivers/acpi/nfit.c:1085:5: error: implicit declaration of > function 'mmio_flush_range' [-Werror=implicit-function-declaration] > > Change nfit.c to include directly for now. > > Signed-off-by: Toshi Kani > Cc: Dan Williams > Cc: Ross Zwisler > --- > Apply on top of libnvdimm-for-next of the nvdimm tree. > This is a temporary fix and please feel free to replace it with > a better solution. This looks correct to me, I'm going to fold it in to where the breakage occurs. Thanks Toshi! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/