Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752179AbbH2DeN (ORCPT ); Fri, 28 Aug 2015 23:34:13 -0400 Received: from mail-vk0-f54.google.com ([209.85.213.54]:36555 "EHLO mail-vk0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751922AbbH2DeM (ORCPT ); Fri, 28 Aug 2015 23:34:12 -0400 MIME-Version: 1.0 In-Reply-To: <1440807366-31223-1-git-send-email-toshi.kani@hp.com> References: <1440807366-31223-1-git-send-email-toshi.kani@hp.com> Date: Fri, 28 Aug 2015 20:34:11 -0700 Message-ID: Subject: Re: [PATCH] pmem, nfit: Fix ARCH_MEMREMAP_PMEM handling on x86_32 From: Dan Williams To: Toshi Kani Cc: Ross Zwisler , Christoph Hellwig , "linux-nvdimm@lists.01.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1229 Lines: 30 On Fri, Aug 28, 2015 at 5:16 PM, Toshi Kani wrote: > ARCH_MEMREMAP_PMEM is defined on x86_64 only per ARCH_HAS_PMEM_API. > The following compile error in __nfit_spa_map() was observed on > x86_32 as it refers ARCH_MEMREMAP_PMEM without #ifdef. > > drivers/acpi/nfit.c:1205:8: error: 'ARCH_MEMREMAP_PMEM' > undeclared (first use in this function) > > Fix it by defining ARCH_MEMREMAP_PMEM to MEMREMAP_WT in > when CONFIG_ARCH_HAS_PMEM_API is not set, i.e. x86_32. > > Remove '#ifdef ARCH_MEMREMAP_PMEM's that are no longer necessary > with this change. > > Also remove the redundant definition of ARCH_MEMREMAP_PMEM in > . > > Signed-off-by: Toshi Kani > Cc: Dan Williams > Cc: Ross Zwisler > Cc: Christoph Hellwig > ---- > Apply on top of libnvdimm-for-next of the nvdimm tree. Thanks Toshi, I'll fold this in to prevent bisection breakage. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/