Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752351AbbH2FKx (ORCPT ); Sat, 29 Aug 2015 01:10:53 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:58183 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751853AbbH2FKw (ORCPT ); Sat, 29 Aug 2015 01:10:52 -0400 Date: Fri, 28 Aug 2015 22:10:49 -0700 (PDT) Message-Id: <20150828.221049.256686243264204039.davem@davemloft.net> To: klimov.linux@gmail.com Cc: aleksey.makarov@auriga.com, netdev@vger.kernel.org, rric@kernel.org, david.daney@cavium.com, Sunil.Goutham@caviumnetworks.com, aleksey.makarov@caviumnetworks.com, linux-kernel@vger.kernel.org, rrichter@cavium.com, robert.richter@caviumnetworks.com, sgoutham@cavium.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next 7/8] net: thunderx: Support for upto 96 queues for a VF From: David Miller In-Reply-To: References: <1440774004-27923-1-git-send-email-aleksey.makarov@auriga.com> <1440774004-27923-7-git-send-email-aleksey.makarov@auriga.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 28 Aug 2015 22:10:52 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1057 Lines: 28 From: Alexey Klimov Date: Sat, 29 Aug 2015 04:45:03 +0300 >> @@ -717,9 +833,24 @@ static void nic_unregister_interrupts(struct nicpf *nic) >> nic_disable_msix(nic); >> } >> >> +static int nic_num_sqs_en(struct nicpf *nic, int vf_en) >> +{ >> + int pos = 0, sqs_per_vf = MAX_SQS_PER_VF_SINGLE_NODE; > > Please check if you really need to initialize 'pos' by zero here. Please do _NOT_ quote hundreds of lines of code only to give feedback on one particular hunk. Quote _ONLY_ the exact context required, nothing more. Everyone has to scroll through all of this unrelated crap you quoted, and that makes more work for everyone. Think particularly of _ME_ who has to be aware of what's going on in every discussion thread for every patch that gets posted to this list. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/