Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752537AbbH2JTV (ORCPT ); Sat, 29 Aug 2015 05:19:21 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:34732 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752453AbbH2JTT (ORCPT ); Sat, 29 Aug 2015 05:19:19 -0400 Date: Sat, 29 Aug 2015 11:19:14 +0200 From: Ingo Molnar To: Borislav Petkov Cc: Huang Rui , Borislav Petkov , Jean Delvare , Guenter Roeck , Andy Lutomirski , Andreas Herrmann , Thomas Gleixner , Peter Zijlstra , "Rafael J. Wysocki" , Len Brown , John Stultz , =?iso-8859-1?Q?Fr=E9d=E9ric?= Weisbecker , lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org, x86@kernel.org, Andreas Herrmann , Aravind Gopalakrishnan , Fengguang Wu , Aaron Lu , Tony Li Subject: Re: [PATCH 09/15] x86, amd: add accessor for number of cores per compute unit Message-ID: <20150829091914.GA8878@gmail.com> References: <1440662866-28716-1-git-send-email-ray.huang@amd.com> <1440662866-28716-10-git-send-email-ray.huang@amd.com> <20150828064814.GB20153@nazgul.tnic> <20150828080418.GB13309@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150828080418.GB13309@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1370 Lines: 39 * Ingo Molnar wrote: > > * Borislav Petkov wrote: > > > On Thu, Aug 27, 2015 at 04:07:40PM +0800, Huang Rui wrote: > > > Add an accessor function amd_get_cores_per_cu() which returns the > > > number of cores per compute unit. > > > > > > In a subsequent patch, we will use this function in fam15h_power > > > driver. > > > > > > Signed-off-by: Huang Rui > > > --- > > > arch/x86/include/asm/processor.h | 1 + > > > arch/x86/kernel/cpu/amd.c | 19 +++++++++++++++++-- > > > 2 files changed, 18 insertions(+), 2 deletions(-) > > > > Btw, this needs an ACK from a tip person if it goes through the hwmon > > tree. > > Looks good to me in theory. > > I suspect we might want to factor the 'compute unit' logic out a bit more if usage > becomes more widespread - but right now it's hwmon drivers only,right? So let me withdraw my ack: the much more important question that I missed first time around, why is this reporting feature living in hwmon, not in perf? We have energy reporting facilities in perf that this should be synced to. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/