Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752835AbbH2KZ7 (ORCPT ); Sat, 29 Aug 2015 06:25:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36077 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752504AbbH2KZ6 (ORCPT ); Sat, 29 Aug 2015 06:25:58 -0400 Date: Sat, 29 Aug 2015 12:25:52 +0200 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Matt Fleming , Jiri Olsa , lkml , David Ahern , Ingo Molnar , Namhyung Kim , Peter Zijlstra , =?iso-8859-1?Q?Rapha=EBl?= Beamonte Subject: Re: [PATCH 02/11] perf tools: Add tracing_path and remove unneeded functions Message-ID: <20150829102552.GC1787@krava.brq.redhat.com> References: <1440596813-12844-1-git-send-email-jolsa@kernel.org> <1440596813-12844-3-git-send-email-jolsa@kernel.org> <20150827224719.GE3596@codeblueprint.co.uk> <20150828162722.GF11407@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150828162722.GF11407@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1060 Lines: 23 On Fri, Aug 28, 2015 at 01:27:22PM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Aug 27, 2015 at 11:47:19PM +0100, Matt Fleming escreveu: > > On Wed, 26 Aug, at 03:46:44PM, Jiri Olsa wrote: > > > There's no need for find_tracing_dir, because perf already > > > searches for debugfs/tracefs mount on start and populate > > > tracing_events_path. > > > > I'm getting a bit lost searching through the git history of these > > functions. Why is it safe to delete these functions? Where did the old > > user that required find_tracing_dir() to mount debugfs disappear to? > > > > The code to do the mount of debugfs/tracefs when perf starts appears > > to have been around for years. Is the mounting operation of > > find_tracing_dir() just dead code? yep, I'll address that in v2.. found TODO in fs.c ;-) jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/